net/spdy/spdy_test_util_common.h - Issue 2095523002: Make //crypto factories return std::unique_ptr<>s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_test_util_common.h

Issue 2095523002: Make //crypto factories return std::unique_ptr<>s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_test_util_common.h

diff --git a/net/spdy/spdy_test_util_common.h b/net/spdy/spdy_test_util_common.h

index e5f908f50f36b07fe09241a214a31b033c22a21b..97e9a536933917e05a29900e821b2c2f8ade6f7d 100644

--- a/net/spdy/spdy_test_util_common.h

+++ b/net/spdy/spdy_test_util_common.h

@@ -164,7 +164,8 @@ class MockECSignatureCreatorFactory : public crypto::ECSignatureCreatorFactory {

~MockECSignatureCreatorFactory() override;

// crypto::ECSignatureCreatorFactory

- crypto::ECSignatureCreator* Create(crypto::ECPrivateKey* key) override;

+ std::unique_ptr<crypto::ECSignatureCreator> Create(

+ crypto::ECPrivateKey* key) override;

private:

DISALLOW_COPY_AND_ASSIGN(MockECSignatureCreatorFactory);