chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc - Issue 2095523002: Make //crypto factories return std::unique_ptr<>s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc

Issue 2095523002: Make //crypto factories return std::unique_ptr<>s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_remover_unittest.cc » ('j') | chrome/browser/net/quota_policy_channel_id_store_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc

diff --git a/chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc b/chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc

index e5ef6c66ac0c752a6703ce9e16fbc722e5b30356..efbdcd3ba1da1e211812ae594070736871f1e912 100644

--- a/chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc

+++ b/chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc

@@ -44,11 +44,11 @@ class BrowsingDataChannelIDHelperTest

channel_id_store->SetChannelID(

base::WrapUnique(new net::ChannelIDStore::ChannelID(

"https://www.google.com:443", base::Time(),

- base::WrapUnique(crypto::ECPrivateKey::Create()))));

+ crypto::ECPrivateKey::Create())));

channel_id_store->SetChannelID(

base::WrapUnique(new net::ChannelIDStore::ChannelID(

"https://www.youtube.com:443", base::Time(),

- base::WrapUnique(crypto::ECPrivateKey::Create()))));

+ crypto::ECPrivateKey::Create())));

}

void FetchCallback(

@@ -142,7 +142,7 @@ TEST_F(BrowsingDataChannelIDHelperTest, CannedEmpty) {

ASSERT_TRUE(helper->empty());

helper->AddChannelID(net::ChannelIDStore::ChannelID(

- origin, base::Time(), base::WrapUnique(crypto::ECPrivateKey::Create())));

+ origin, base::Time(), crypto::ECPrivateKey::Create()));

ASSERT_FALSE(helper->empty());

helper->Reset();

ASSERT_TRUE(helper->empty());