components/crx_file/crx_file.cc - Issue 2095523002: Make //crypto factories return std::unique_ptr<>s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crx_file/crx_file.cc

Issue 2095523002: Make //crypto factories return std::unique_ptr<>s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: I'm blind Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/crx_file/crx_file.cc

diff --git a/components/crx_file/crx_file.cc b/components/crx_file/crx_file.cc

index 7a310aca98828693d9b2bc4e235fbb76b7b7b36f..2445ef1e6629bf5c439bfe0551acddde6d53ce60 100644

--- a/components/crx_file/crx_file.cc

+++ b/components/crx_file/crx_file.cc

@@ -111,7 +111,7 @@ CrxFile::ValidateError CrxFile::ValidateSignature(

base::ScopedFILE file(base::OpenFile(crx_path, "rb"));

std::unique_ptr<crypto::SecureHash> hash;

if (!expected_hash.empty())

- hash.reset(crypto::SecureHash::Create(crypto::SecureHash::SHA256));

+ hash = crypto::SecureHash::Create(crypto::SecureHash::SHA256);

if (!file.get())

return ValidateError::CRX_FILE_NOT_READABLE;