Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2095473003: Add missing header file for chrome_content_client.cc. (Closed)

Created:
4 years, 6 months ago by leonhsl(Using Gerrit)
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing header file for chrome_content_client.cc. chrome/common/chrome_content_client.cc uses base::WrapUnique but does not include the header file "base/memory/ptr_util.h", this CL adds it explicitly. The implicit including will cause trybots failure just like what happened in https://codereview.chromium.org/2063683002/#ps140001. BUG= Committed: https://crrev.com/ea5f432cad6e8887f8375af621ca6d02af1ae9bf Cr-Commit-Position: refs/heads/master@{#401879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/common/chrome_content_client.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095473003/1
4 years, 6 months ago (2016-06-23 03:56:43 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 04:47:41 UTC) #4
leonhsl(Using Gerrit)
Would you PTAL at this? Thanks~
4 years, 6 months ago (2016-06-23 05:05:38 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-24 13:36:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095473003/1
4 years, 6 months ago (2016-06-24 14:47:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/233944)
4 years, 6 months ago (2016-06-24 15:45:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095473003/1
4 years, 6 months ago (2016-06-24 16:04:55 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 16:34:26 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 16:37:18 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea5f432cad6e8887f8375af621ca6d02af1ae9bf
Cr-Commit-Position: refs/heads/master@{#401879}

Powered by Google App Engine
This is Rietveld 408576698