Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2095473002: Revert of Roll internal Google Play Services (Chromium part) (Closed)

Created:
4 years, 6 months ago by paulmiller
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll internal Google Play Services (Chromium part) (patchset #1 id:1 of https://codereview.chromium.org/2088073002/ ) Reason for revert: broke Original issue's description: > Roll internal Google Play Services (Chromium part) > > BUG=613768 > > TBR=jbudorick@chromium.org,agrieve@chromium.org,mariakhomenko@chromium.org > NOTRY=true > > (skipping trybots because previous, identical patch > passed CQ, and because this is needed to fix the tree) > > Committed: https://crrev.com/c3199997a359e45fee3526111b4a5d25d8e6ea1b > Cr-Commit-Position: refs/heads/master@{#401419} TBR=jbudorick@chromium.org,agrieve@chromium.org,mariakhomenko@chromium.org,sgurun@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=613768 Committed: https://crrev.com/9ad7108b358c2707f0bd42e60cceb73f97830860 Cr-Commit-Position: refs/heads/master@{#401454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -57 lines) Patch
M build/android/play_services/preprocess.py View 3 chunks +17 lines, -35 lines 0 comments Download
M build/config/android/internal_rules.gni View 4 chunks +1 line, -16 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
paulmiller
Created Revert of Roll internal Google Play Services (Chromium part)
4 years, 6 months ago (2016-06-22 23:16:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095473002/1
4 years, 6 months ago (2016-06-22 23:18:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 23:18:55 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 23:21:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ad7108b358c2707f0bd42e60cceb73f97830860
Cr-Commit-Position: refs/heads/master@{#401454}

Powered by Google App Engine
This is Rietveld 408576698