Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2095433003:
DevTools: Center vertically around a highlighted element (Closed)
|
Created:
4 years, 6 months ago by einbinder Modified:
4 years, 5 months ago Reviewers:
dgozman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Center vertically around a highlighted element
Fixes a regression from https://codereview.chromium.org/1461283004/
BUG=604438
Committed: https://crrev.com/0dd09f399c3ce6cb22c4074c3b46c1556b25126a
Cr-Commit-Position: refs/heads/master@{#402940}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 20 (8 generated)
einbinder@chromium.org changed reviewers: + dgozman@chromium.org
https://codereview.chromium.org/2095433003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElementHighlighter.js (right): https://codereview.chromium.org/2095433003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElementHighlighter.js:78: treeElement.reveal(true); Does this work for context menu "Inspect" item?
On 2016/06/24 17:41:06, dgozman wrote: > https://codereview.chromium.org/2095433003/diff/1/third_party/WebKit/Source/d... > File > third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElementHighlighter.js > (right): > > https://codereview.chromium.org/2095433003/diff/1/third_party/WebKit/Source/d... > third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElementHighlighter.js:78: > treeElement.reveal(true); > Does this work for context menu "Inspect" item? Yes, the right click inspect element uses reveal(true) already. The problem was because if an element was already on screen it doesn't scroll at all, and hovering revealed but didn't center. So hovering and then clicking was never able to center.
Let's fix more places where reveal() should be centered. Please also note this fixes regression from https://codereview.chromium.org/1461283004/ in patch description.
On 2016/06/27 21:46:42, dgozman wrote: > Let's fix more places where reveal() should be centered. > Please also note this fixes regression from > https://codereview.chromium.org/1461283004/ in patch description. The other places reveal is used either aren't in the elements panel, or are specifically called out as shouldn't center (search and arrow keys)
Description was changed from ========== Center vertically around a highlighted element BUG=604438 ========== to ========== DevTools: Center vertically around a highlighted element BUG=604438 ==========
lgtm. Please update patch description.
Description was changed from ========== DevTools: Center vertically around a highlighted element BUG=604438 ========== to ========== DevTools: Center vertically around a highlighted element Fixes a regression from https://codereview.chromium.org/1461283004/ BUG=604438 ==========
The CQ bit was checked by einbinder@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by einbinder@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DevTools: Center vertically around a highlighted element Fixes a regression from https://codereview.chromium.org/1461283004/ BUG=604438 ========== to ========== DevTools: Center vertically around a highlighted element Fixes a regression from https://codereview.chromium.org/1461283004/ BUG=604438 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== DevTools: Center vertically around a highlighted element Fixes a regression from https://codereview.chromium.org/1461283004/ BUG=604438 ========== to ========== DevTools: Center vertically around a highlighted element Fixes a regression from https://codereview.chromium.org/1461283004/ BUG=604438 Committed: https://crrev.com/0dd09f399c3ce6cb22c4074c3b46c1556b25126a Cr-Commit-Position: refs/heads/master@{#402940} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0dd09f399c3ce6cb22c4074c3b46c1556b25126a Cr-Commit-Position: refs/heads/master@{#402940} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
