Chromium Code Reviews
DescriptionSet maxilksize to 4 GB and enable for blink_core
blink_core normally cannot use incremental linking because it hits the
(undocumented) LNK1210 error:
LINK : fatal error LNK1210: exceeded internal ILK size limit; link with /INCREMENTAL:NO
This change attempts to fix this by using the undocumented /maxilksize switch to set the
ILK limit to 4 GB instead of 2 GB.
This works with no errors, and a 2.9 GB blink_core.ilk file is created, but links continue
to take the same amount of time, and blink_core.dll.lib continues to be updated (thus
causing dependent DLLs to needlessly be linked) when a core file such as this is touched:
touch third_party\WebKit\Source\core\CoreInitializer.cpp
Getting incremental linking to work for this DLL would dramatically improve incremental
build times of blink\webkit.
The gn settings I used for this test are:
is_component_build = true
is_debug = true
enable_nacl = false
is_win_fastlink = true
These can be set with "gn args out\gn_test"
See this connect bug for tracking:
https://connect.microsoft.com/VisualStudio/feedback/details/2846790
BUG=608801
Patch Set 1 #
Messages
Total messages: 1 (1 generated)
|
||||||||||||||||||||||||||||