Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2095433002: Set maxilksize to 4 GB and enable for blink_core (Closed)

Created:
4 years, 6 months ago by brucedawson
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set maxilksize to 4 GB and enable for blink_core blink_core normally cannot use incremental linking because it hits the (undocumented) LNK1210 error: LINK : fatal error LNK1210: exceeded internal ILK size limit; link with /INCREMENTAL:NO This change attempts to fix this by using the undocumented /maxilksize switch to set the ILK limit to 4 GB instead of 2 GB. This works with no errors, and a 2.9 GB blink_core.ilk file is created, but links continue to take the same amount of time, and blink_core.dll.lib continues to be updated (thus causing dependent DLLs to needlessly be linked) when a core file such as this is touched: touch third_party\WebKit\Source\core\CoreInitializer.cpp Getting incremental linking to work for this DLL would dramatically improve incremental build times of blink\webkit. The gn settings I used for this test are: is_component_build = true is_debug = true enable_nacl = false is_win_fastlink = true These can be set with "gn args out\gn_test" See this connect bug for tracking: https://connect.microsoft.com/VisualStudio/feedback/details/2846790 BUG=608801

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/config/win/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
brucedawson
4 years, 6 months ago (2016-06-22 21:12:06 UTC) #1
Description was changed from

==========
Set maxilksize to 4 GB and enable for blink_core

blink_core normally cannot use incremental linking because it hits the
(undocumented) LNK1210 error:

    LINK : fatal error LNK1210: exceeded internal ILK size limit; link with
/INCREMENTAL:NO

This change attempts to fix this by using the undocumented /maxilksize switch to
set the
ILK limit to 4 GB instead of 2 GB.

This works with no errors, and a 2.9 GB blink_core.ilk file is created, but
links continue
to take the same amount of time, and blink_core.dll.lib continues to be updated
(thus
causing dependent DLLs to needlessly be linked) when a core file such as this is
touched:

    touch third_party\WebKit\Source\core\CoreInitializer.cpp

Getting incremental linking to work for this DLL would dramatically improve
incremental
build times of blink\webkit.

The gn settings I used for this test are:

    is_component_build = true
    is_debug = true
    enable_nacl = false
    is_win_fastlink = true

These can be set with "gn args out\gn_test"

BUG=608801
==========

to

==========
Set maxilksize to 4 GB and enable for blink_core

blink_core normally cannot use incremental linking because it hits the
(undocumented) LNK1210 error:

    LINK : fatal error LNK1210: exceeded internal ILK size limit; link with
/INCREMENTAL:NO

This change attempts to fix this by using the undocumented /maxilksize switch to
set the
ILK limit to 4 GB instead of 2 GB.

This works with no errors, and a 2.9 GB blink_core.ilk file is created, but
links continue
to take the same amount of time, and blink_core.dll.lib continues to be updated
(thus
causing dependent DLLs to needlessly be linked) when a core file such as this is
touched:

    touch third_party\WebKit\Source\core\CoreInitializer.cpp

Getting incremental linking to work for this DLL would dramatically improve
incremental
build times of blink\webkit.

The gn settings I used for this test are:

    is_component_build = true
    is_debug = true
    enable_nacl = false
    is_win_fastlink = true

These can be set with "gn args out\gn_test"

See this connect bug for tracking:

https://connect.microsoft.com/VisualStudio/feedback/details/2846790

BUG=608801
==========

Powered by Google App Engine
This is Rietveld 408576698