TabManagerDelegate: Better prioritize ARC processes.

chrome/browser/chromeos/arc/arc_process.h

 // Copyright 2016 The Chromium Authors. All rights reserved.

[Yusuke Sato, 2016/06/27 16:40:51]

Please file a placeholder bug (http://crbug.com/new) and use the bug for the
BUG= line.

[cylee1, 2016/07/14 19:15:24]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_PROCESS_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_ARC_PROCESS_H_
 
 #include <string>
 #include <vector>
 

[Yusuke Sato, 2016/06/27 16:40:50]

#include <stdint.h> ?

[cylee1, 2016/07/14 19:15:24]

Done.

 #include "base/process/process_handle.h"
 #include "components/arc/common/process.mojom.h"
 
 namespace arc {
 
 class ArcProcess {
  public:
+  // TODO(cylee): Deprecate process_state if possible.
   ArcProcess(base::ProcessId nspid,
              base::ProcessId pid,
              const std::string& process_name,
-             mojom::ProcessState process_state);
+             mojom::ProcessState process_state,
+             int adj,

[Yusuke Sato, 2016/06/27 16:40:50]

Can you use a more descriptive name for this?

https://google.github.io/styleguide/cppguide.html#General_Naming_Rules says
"eschew abbreviation."

[cylee1, 2016/07/14 19:15:24]

The parameter is replaced by is_focused.

+             int64_t last_activity_time);
   ~ArcProcess();
 
   ArcProcess(ArcProcess&& other);
   ArcProcess& operator=(ArcProcess&& other);
 
   base::ProcessId nspid() const { return nspid_; }
   base::ProcessId pid() const { return pid_; }
   const std::string& process_name() const { return process_name_; }
   mojom::ProcessState process_state() const { return process_state_; }
+  int adj() const { return adj_; }
+  int64_t last_activity_time() const { return last_activity_time_; }
   std::vector<std::string>& packages() { return packages_; }
   const std::vector<std::string>& packages() const { return packages_; }
 
  private:
   base::ProcessId nspid_;
   base::ProcessId pid_;
   std::string process_name_;
   mojom::ProcessState process_state_;
+  int adj_;

[Yusuke Sato, 2016/06/27 16:40:50]

Please document what this is.

[cylee1, 2016/07/14 19:15:24]

Replaced.

+  int64_t last_activity_time_;

[Yusuke Sato, 2016/06/27 16:40:51]

same. (what is the epoch of the time btw?)

[cylee1, 2016/07/14 19:15:24]

Done.

   std::vector<std::string> packages_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcProcess);
 };
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_PROCESS_H_