Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2095393002: Add posciak and wuchengli to WebRTC HW decoder and encoder files (Closed)

Created:
4 years, 5 months ago by wuchengli
Modified:
4 years, 5 months ago
Reviewers:
mcasas, Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add posciak and wuchengli to WebRTC HW decoder and encoder files Covers: rtc_video_decoder.cc rtc_video_decoder_factory.cc rtc_video_decoder_factory.h rtc_video_decoder.h rtc_video_decoder_unittest.cc rtc_video_encoder.cc rtc_video_encoder_factory.cc rtc_video_encoder_factory.h rtc_video_encoder.h The above files have been moved to content/renderer/media/gpu. BUG=None TEST=Build Chrome on ChromeOS Committed: https://crrev.com/6f7ef8a5b3deacc6d2ab70f282ff93486947f5a1 Cr-Commit-Position: refs/heads/master@{#403168}

Patch Set 1 #

Total comments: 2

Patch Set 2 : move files to content/renderer/media/gpu #

Total comments: 2

Patch Set 3 : remove duplicated owners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2743 lines) Patch
M content/content_renderer.gypi View 1 2 chunks +8 lines, -8 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/media/DEPS View 1 1 chunk +0 lines, -2 lines 0 comments Download
A content/renderer/media/gpu/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + content/renderer/media/gpu/rtc_video_decoder.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/media/gpu/rtc_video_decoder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/media/gpu/rtc_video_decoder_factory.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/media/gpu/rtc_video_decoder_factory.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + content/renderer/media/gpu/rtc_video_decoder_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/media/gpu/rtc_video_encoder.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/media/gpu/rtc_video_encoder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/media/gpu/rtc_video_encoder_factory.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/media/gpu/rtc_video_encoder_factory.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
D content/renderer/media/rtc_video_decoder.h View 1 1 chunk +0 lines, -309 lines 0 comments Download
D content/renderer/media/rtc_video_decoder.cc View 1 1 chunk +0 lines, -900 lines 0 comments Download
D content/renderer/media/rtc_video_decoder_factory.h View 1 1 chunk +0 lines, -49 lines 0 comments Download
D content/renderer/media/rtc_video_decoder_factory.cc View 1 1 chunk +0 lines, -36 lines 0 comments Download
D content/renderer/media/rtc_video_decoder_unittest.cc View 1 1 chunk +0 lines, -328 lines 0 comments Download
D content/renderer/media/rtc_video_encoder.h View 1 1 chunk +0 lines, -83 lines 0 comments Download
D content/renderer/media/rtc_video_encoder.cc View 1 1 chunk +0 lines, -877 lines 0 comments Download
D content/renderer/media/rtc_video_encoder_factory.h View 1 1 chunk +0 lines, -48 lines 0 comments Download
D content/renderer/media/rtc_video_encoder_factory.cc View 1 1 chunk +0 lines, -81 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 30 (15 generated)
wuchengli
4 years, 5 months ago (2016-06-27 14:17:22 UTC) #3
mcasas
https://codereview.chromium.org/2095393002/diff/1/content/renderer/media/OWNERS File content/renderer/media/OWNERS (right): https://codereview.chromium.org/2095393002/diff/1/content/renderer/media/OWNERS#newcode18 content/renderer/media/OWNERS:18: per-file rtc_video_*=wuchengli@chromium.org I'm not opposed to this change, but ...
4 years, 5 months ago (2016-06-27 17:05:32 UTC) #4
wuchengli
https://codereview.chromium.org/2095393002/diff/1/content/renderer/media/OWNERS File content/renderer/media/OWNERS (right): https://codereview.chromium.org/2095393002/diff/1/content/renderer/media/OWNERS#newcode18 content/renderer/media/OWNERS:18: per-file rtc_video_*=wuchengli@chromium.org On 2016/06/27 17:05:31, mcasas wrote: > I'm ...
4 years, 5 months ago (2016-06-28 03:54:58 UTC) #5
mcasas
On 2016/06/28 03:54:58, wuchengli wrote: > https://codereview.chromium.org/2095393002/diff/1/content/renderer/media/OWNERS > File content/renderer/media/OWNERS (right): > > https://codereview.chromium.org/2095393002/diff/1/content/renderer/media/OWNERS#newcode18 > ...
4 years, 5 months ago (2016-06-28 04:38:14 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095393002/20001
4 years, 5 months ago (2016-06-29 15:02:26 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095393002/40001
4 years, 5 months ago (2016-06-29 15:06:46 UTC) #15
wuchengli
Moved to content/renderer/media/gpu. PTAL.
4 years, 5 months ago (2016-06-29 15:06:54 UTC) #16
mcasas
RS LGTM % my comment. https://codereview.chromium.org/2095393002/diff/40001/content/renderer/media/gpu/OWNERS File content/renderer/media/gpu/OWNERS (right): https://codereview.chromium.org/2095393002/diff/40001/content/renderer/media/gpu/OWNERS#newcode3 content/renderer/media/gpu/OWNERS:3: miu@chromium.org OWNERS are hierarchical ...
4 years, 5 months ago (2016-06-29 15:09:43 UTC) #17
wuchengli
https://codereview.chromium.org/2095393002/diff/40001/content/renderer/media/gpu/OWNERS File content/renderer/media/gpu/OWNERS (right): https://codereview.chromium.org/2095393002/diff/40001/content/renderer/media/gpu/OWNERS#newcode3 content/renderer/media/gpu/OWNERS:3: miu@chromium.org On 2016/06/29 15:09:43, mcasas wrote: > OWNERS are ...
4 years, 5 months ago (2016-06-29 15:32:55 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095393002/60001
4 years, 5 months ago (2016-06-29 15:33:31 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 16:21:55 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095393002/60001
4 years, 5 months ago (2016-06-30 14:05:16 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 5 months ago (2016-06-30 14:09:35 UTC) #27
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 14:09:39 UTC) #28
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 14:10:51 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6f7ef8a5b3deacc6d2ab70f282ff93486947f5a1
Cr-Commit-Position: refs/heads/master@{#403168}

Powered by Google App Engine
This is Rietveld 408576698