Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 209533002: Fix debuggersupport=off build after r17184 and r18149. (Closed)

Created:
6 years, 9 months ago by kennyluck
Modified:
6 years, 9 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
http://github.com/v8/v8@master
Visibility:
Public.

Description

Fix debuggersupport=off build after r17184 and r18149. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20193

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/d8-debug.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
kennyluck
I think we might want to make most use of ENABLE_DEBUGGER_SUPPORT to just a flag ...
6 years, 9 months ago (2014-03-23 17:04:04 UTC) #1
rossberg
lgtm
6 years, 9 months ago (2014-03-24 07:53:51 UTC) #2
kennyluck
The CQ bit was checked by kanghao.lkh@alibaba-inc.com
6 years, 9 months ago (2014-03-24 08:40:13 UTC) #3
kennyluck
On 2014/03/24 08:40:13, kennyluck wrote: > The CQ bit was checked by mailto:kanghao.lkh@alibaba-inc.com Meh. I ...
6 years, 9 months ago (2014-03-24 09:00:20 UTC) #4
kennyluck
The CQ bit was unchecked by kanghao.lkh@alibaba-inc.com
6 years, 9 months ago (2014-03-24 12:01:57 UTC) #5
kennyluck
The CQ bit was checked by kanghao.lkh@alibaba-inc.com
6 years, 9 months ago (2014-03-24 12:02:03 UTC) #6
kennyluck
The CQ bit was unchecked by kanghao.lkh@alibaba-inc.com
6 years, 9 months ago (2014-03-24 12:03:28 UTC) #7
kennyluck
On 2014/03/24 12:03:28, kennyluck wrote: > The CQ bit was unchecked by mailto:kanghao.lkh@alibaba-inc.com Meh. I ...
6 years, 9 months ago (2014-03-24 12:10:06 UTC) #8
rossberg
6 years, 9 months ago (2014-03-24 13:04:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r20193 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698