Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2095323002: X87: [builtins] Always pass target and new target to C++ builtins. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Always pass target and new target to C++ builtins. port f5b83dec4ebd8c786292073cc45a078d716fba0b (r37061) original commit message: As a first step towards showing builtin frames in stack traces, we will now push target and new target unconditionally. Since the various specializations of BuiltinArguments are made redundant by this change, we can remove them and all related code. BUG= Committed: https://crrev.com/d1e6a2e21a53a787eaef6f66e237bda666570d68 Cr-Commit-Position: refs/heads/master@{#37282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +6 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-27 09:41:17 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-06-27 09:52:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095323002/1
4 years, 5 months ago (2016-06-27 09:52:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 10:17:04 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 10:19:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1e6a2e21a53a787eaef6f66e237bda666570d68
Cr-Commit-Position: refs/heads/master@{#37282}

Powered by Google App Engine
This is Rietveld 408576698