Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2095313002:
[test] Sync unittests gn build (Closed)
|
Created:
4 years, 5 months ago by Michael Achenbach Modified:
4 years, 5 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[test] Sync unittests gn build
Fix after:
https://codereview.chromium.org/2060743002/
https://codereview.chromium.org/2086653003/
BUG=v8:5086, v8:5092, v8:4124
TBR=bmeurer@chromium.org, yangguo@chromium.org, bbudge@chromium.org
NOTRY=true
Committed: https://crrev.com/a93f1bdb834b856fe87d338487cc966f151e8337
Cr-Commit-Position: refs/heads/master@{#37274}
Patch Set 1 #Patch Set 2 : More tests #Messages
Total messages: 17 (10 generated)
Description was changed from ========== [test] Sync unittests gn build BUG= ========== to ========== [test] Sync unittests gn build Fix after https://codereview.chromium.org/2060743002/ BUG=v8:5086, v8:5092 TBR=bmeurer@chromium.org, yangguo@chromium.org NOTRY=true ==========
machenbach@chromium.org changed reviewers: + bmeurer@chromium.org, yangguo@chromium.org
PTAL
On 2016/06/27 07:49:42, Michael Achenbach wrote: > PTAL lgtm.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by machenbach@chromium.org
Description was changed from ========== [test] Sync unittests gn build Fix after https://codereview.chromium.org/2060743002/ BUG=v8:5086, v8:5092 TBR=bmeurer@chromium.org, yangguo@chromium.org NOTRY=true ========== to ========== [test] Sync unittests gn build Fix after: https://codereview.chromium.org/2060743002/ https://codereview.chromium.org/2086653003/ BUG=v8:5086, v8:5092, v8:4124 TBR=bmeurer@chromium.org, yangguo@chromium.org, bbudge@chromium.org NOTRY=true ==========
machenbach@chromium.org changed reviewers: + bbudge@chromium.org
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org Link to the patchset: https://codereview.chromium.org/2095313002/#ps20001 (title: "More tests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [test] Sync unittests gn build Fix after: https://codereview.chromium.org/2060743002/ https://codereview.chromium.org/2086653003/ BUG=v8:5086, v8:5092, v8:4124 TBR=bmeurer@chromium.org, yangguo@chromium.org, bbudge@chromium.org NOTRY=true ========== to ========== [test] Sync unittests gn build Fix after: https://codereview.chromium.org/2060743002/ https://codereview.chromium.org/2086653003/ BUG=v8:5086, v8:5092, v8:4124 TBR=bmeurer@chromium.org, yangguo@chromium.org, bbudge@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [test] Sync unittests gn build Fix after: https://codereview.chromium.org/2060743002/ https://codereview.chromium.org/2086653003/ BUG=v8:5086, v8:5092, v8:4124 TBR=bmeurer@chromium.org, yangguo@chromium.org, bbudge@chromium.org NOTRY=true ========== to ========== [test] Sync unittests gn build Fix after: https://codereview.chromium.org/2060743002/ https://codereview.chromium.org/2086653003/ BUG=v8:5086, v8:5092, v8:4124 TBR=bmeurer@chromium.org, yangguo@chromium.org, bbudge@chromium.org NOTRY=true Committed: https://crrev.com/a93f1bdb834b856fe87d338487cc966f151e8337 Cr-Commit-Position: refs/heads/master@{#37274} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a93f1bdb834b856fe87d338487cc966f151e8337 Cr-Commit-Position: refs/heads/master@{#37274}
Message was sent while issue was closed.
Missed this. LGTM Thanks! |
