Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: third_party/WebKit/Source/core/css/RemoteFontFaceSource.h

Issue 2095293002: WebFonts intervention: Add metrics only for miss-cached loading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: check memory cache too Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
diff --git a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
index d52613625046933dc47470d147d0865a2e271af1..bfa962220c5162afd81144ecfed87e50c5dd52b7 100644
--- a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
+++ b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
@@ -64,14 +64,14 @@ private:
FontLoadHistograms() : m_loadStartTime(0), m_blankPaintTime(0), m_isLongLimitExceeded(false) { }
void loadStarted();
void fallbackFontPainted(DisplayPeriod);
- void fontLoaded(bool isInterventionTriggered);
+ void fontLoaded(bool isInterventionTriggered, bool isLoadedFromCache);
kinuko 2016/06/27 12:06:24 usually prefer enum over bool... but ok this is in
void longLimitExceeded(bool isInterventionTriggered);
void recordFallbackTime(const FontResource*);
void recordRemoteFont(const FontResource*);
bool hadBlankText() { return m_blankPaintTime; }
private:
void recordLoadTimeHistogram(const FontResource*, int duration);
- void recordInterventionResult(bool triggered);
+ void recordInterventionResult(bool triggered, bool loadedFromCache);
kinuko 2016/06/27 12:06:24 loadedFromCache -> isLoadedFromCache for consisten
Takashi Toyoshima 2016/06/28 05:38:18 Done with triggered -> isTriggered.
double m_loadStartTime;
double m_blankPaintTime;
bool m_isLongLimitExceeded;
@@ -86,6 +86,7 @@ private:
DisplayPeriod m_period;
FontLoadHistograms m_histograms;
bool m_isInterventionTriggered;
+ bool m_isLoadedFromMemoryCache;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698