MacViews: Don't handle character events in textfield_unittest's MockInputMethod::DispatchKeyEvent.

ui/views/controls/textfield/textfield_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/textfield.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <set>
@@ skipping 129 matching lines @@
 }
 
 bool MockInputMethod::OnUntranslatedIMEMessage(const base::NativeEvent& event,
                                                NativeEventResult* result) {
   if (result)
     *result = NativeEventResult();
   return false;
 }
 
 void MockInputMethod::DispatchKeyEvent(ui::KeyEvent* key) {
+// On Mac, emulate InputMethodMac behavior.
+#if defined(OS_MACOSX)
+  ignore_result(DispatchKeyEventPostIME(key));
+  return;
+#endif
+
   // Checks whether the key event is from EventGenerator on Windows which will
   // generate key event for WM_CHAR.
   // The MockInputMethod will insert char on WM_KEYDOWN so ignore WM_CHAR here.
   if (key->is_char() && key->HasNativeEvent()) {
     key->SetHandled();
     return;
   }
 
   bool handled = !IsTextInputTypeNone() && HasComposition();
   ClearStates();
@@ skipping 343 matching lines @@
   }
 
   void SendKeyEvent(base::char16 ch) {
     if (ch < 0x80) {
       ui::KeyboardCode code =
           ch == ' ' ? ui::VKEY_SPACE :
           static_cast<ui::KeyboardCode>(ui::VKEY_A + ch - 'a');
       SendKeyEvent(code);
     } else {
       // For unicode characters, assume they come from IME rather than the
-      // keyboard. So they are dispatched directly to the input method.
+      // keyboard. So they are dispatched directly to the input method. But on
+      // Mac, key events don't pass through InputMethod. Hence they are
+      // dispatched regularly.
       ui::KeyEvent event(ch, ui::VKEY_UNKNOWN, ui::EF_NONE);
+#if defined(OS_MACOSX)
+      event_generator_->Dispatch(&event);

[tapted, 2016/06/29 07:21:39]

can you explain (in the CL description perhaps) why this is necessary in
addition to the short-circuit in MockInputMethod?

[karandeepb, 2016/06/29 07:54:07]

Done.

+#else
       input_method_->DispatchKeyEvent(&event);

[karandeepb, 2016/06/29 01:42:41]

Not sure if the event needs to be dispatched directly to |input_method_| on
other platforms. The tests also work with a regular dispatch.

[tapted, 2016/06/29 07:21:39]

This looks ok.. Event dispatch can be a bit crazy, so if the test coverage is
still good with a shorter path, that typically makes them easier to debug.

+#endif
     }
   }
 
   // Sends a platform-specific move (and select) to the logical start of line.
   // Eg. this should move (and select) to the right end of line for RTL text.
   void SendHomeEvent(bool shift) {
     if (TestingNativeMac()) {
       // [NSResponder moveToBeginningOfLine:] is the correct way to do this on
       // Mac, but that doesn't have a default key binding. Since
       // views::Textfield doesn't currently support multiple lines, the same
@@ skipping 2152 matching lines @@
 
   textfield_->SetTextInputType(ui::TEXT_INPUT_TYPE_PASSWORD);
   ui::AXViewState state_protected;
   textfield_->GetAccessibleState(&state_protected);
   EXPECT_EQ(ui::AX_ROLE_TEXT_FIELD, state_protected.role);
   EXPECT_EQ(ASCIIToUTF16("********"), state_protected.value);
   EXPECT_TRUE(state_protected.HasStateFlag(ui::AX_STATE_PROTECTED));
 }
 
 }  // namespace views