MacViews: Don't handle character events in textfield_unittest's MockInputMethod::DispatchKeyEvent.

ui/events/test/cocoa_test_event_utils.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.

[tapted, 2016/06/29 07:21:39]

Note there's also ui/base/ime/mock_input_method.h, but this is just modifying
textfield_unittests's mock input method, so the CL description is a bit
confusing. I'd replace "MockInputMethod" with "textfield_unittest's mocked
InputMethod" or something like that

[karandeepb, 2016/06/29 07:54:07]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 #include <mach/mach_time.h>
 #include <stdint.h>
 
 #import "ui/events/keycodes/keyboard_code_conversion_mac.h"
 #include "ui/events/test/cocoa_test_event_utils.h"
 
@@ skipping 184 matching lines @@
   // Note on Mac (unlike other platforms) shift while caps is down does not go
   // back to lowercase.
   if (keycode >= ui::VKEY_A && keycode <= ui::VKEY_Z &&
       (flags & NSAlphaShiftKeyMask))
     flags |= NSShiftKeyMask;
 
   // Clear caps regardless -- MacKeyCodeForWindowsKeyCode doesn't implement
   // logic to support it.
   flags &= ~NSAlphaShiftKeyMask;
 
+  // Call sites may generate unicode character events with an undefined
+  // keycode. Since it's not feasible to determine the correct keycode for
+  // each unicode character, we use a dummy keycode corresponding to key 'A'.

[tapted, 2016/06/29 07:21:39]

(also this probably only really matters for things with a NSCommandKeyMask since
|shifted_character| uses dom_key.ToCharacter() just below.)

[karandeepb, 2016/06/29 07:54:07]

I didn't get the bit about NSCommandKeyMask. This is needed for character events
with an undefined keycode. 

+  if (dom_key.IsCharacter() && keycode == ui::VKEY_UNKNOWN)
+    keycode = ui::VKEY_A;
+
   unichar character;
   unichar shifted_character;
   int macKeycode = ui::MacKeyCodeForWindowsKeyCode(
       keycode, flags, &shifted_character, &character);
 
   if (macKeycode < 0)
     return nil;
 
   // If an explicit unicode character is provided, use that instead of the one
   // derived from the keycode.
@@ skipping 46 matching lines @@
                                      context:nil
                                   characters:characters
                  charactersIgnoringModifiers:charactersIgnoringModifiers
                                    isARepeat:NO
                                      keyCode:(unsigned short)macKeycode];
 
   return event;
 }
 
 }  // namespace cocoa_test_event_utils