typedef uint16_t SkGlyphID

typedef uint16_t SkGlyphID

This goes well with our existing `typedef int32_t SkUnichar`.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2095263003

Committed: https://skia.googlesource.com/skia/+/d0e95a524c20932e0f4e68bab43995188a281395

[hal.canary, 2016-06-27 13:27:08]

Description was changed from

==========
typedef uint16_t SkGlyphID

This goes well with our existing `typedef int32_t SkUnichar`.
==========

to

==========
typedef uint16_t SkGlyphID

This goes well with our existing `typedef int32_t SkUnichar`.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2095263003
==========

[hal.canary, 2016-06-27 13:27:48]

halcanary@google.com changed reviewers:
+ bungeman@google.com, reed@google.com

[hal.canary, 2016-06-27 13:27:48]

Is this a good idea?

[bungeman-skia, 2016-07-05 18:23:48]

I'm generally ok with giving things like this names. I take it this change is
just the public API part of this, leaving the heavy typing to later.

Note that we currently have internal names like "SkGlyphCache { typedef uint32_t
PackedGlyphID }" and "GrGlyph { typedef uint32_t PackedID }".

[reed1, 2016-07-06 13:20:31]

On 2016/07/05 18:23:48, bungeman-skia wrote:
> I'm generally ok with giving things like this names. I take it this change is
> just the public API part of this, leaving the heavy typing to later.
> 
> Note that we currently have internal names like "SkGlyphCache { typedef
uint32_t
> PackedGlyphID }" and "GrGlyph { typedef uint32_t PackedID }".

PackedGlyphID is != GlyphID, since it has other crud in it (e.g. fractional
positioning).

[reed1, 2016-07-06 13:21:06]

api lgtm

[hal.canary, 2016-07-25 13:53:17]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2016-07-25 13:53:17]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2095263003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-25 13:53:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 14:18:14]

Description was changed from

==========
typedef uint16_t SkGlyphID

This goes well with our existing `typedef int32_t SkUnichar`.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2095263003
==========

to

==========
typedef uint16_t SkGlyphID

This goes well with our existing `typedef int32_t SkUnichar`.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2095263003

Committed:
https://skia.googlesource.com/skia/+/d0e95a524c20932e0f4e68bab43995188a281395
==========

[commit-bot: I haz the power, 2016-07-25 14:18:15]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d0e95a524c20932e0f4e68bab43995188a281395