Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2095253002:
Remove EventSender from SVGUseElement (Closed)
|
Created:
4 years, 5 months ago by hiroshige Modified:
4 years, 2 months ago Reviewers:
fs CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove EventSender from SVGUseElement
BUG=624697
Committed: https://crrev.com/79dc95f170313734d2e0e61733e7064bb34f0c6b
Cr-Commit-Position: refs/heads/master@{#422375}
Patch Set 1 #Patch Set 2 : Use DOMManipulation #Patch Set 3 : Rebase #
Messages
Total messages: 27 (14 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Remove EventSender from SVGUseElement BUG= ========== to ========== Remove EventSender from SVGUseElement BUG=624697 ==========
hiroshige@chromium.org changed reviewers: + fs@opera.com
Could you take a look?
lgtm
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/Source/core/svg/SVGUseElement.cpp:
While running git apply --index -3 -p1;
error: patch failed: third_party/WebKit/Source/core/svg/SVGUseElement.cpp:46
Falling back to three-way merge...
Applied patch to 'third_party/WebKit/Source/core/svg/SVGUseElement.cpp' with
conflicts.
U third_party/WebKit/Source/core/svg/SVGUseElement.cpp
Patch: third_party/WebKit/Source/core/svg/SVGUseElement.cpp
Index: third_party/WebKit/Source/core/svg/SVGUseElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGUseElement.cpp
b/third_party/WebKit/Source/core/svg/SVGUseElement.cpp
index
538be626e772cab441057c370ac76cad2ca6040e..3ea183cb31ebf103029df86ad9f345ca6e4b5747
100644
--- a/third_party/WebKit/Source/core/svg/SVGUseElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGUseElement.cpp
@@ -30,6 +30,7 @@
#include "core/dom/Document.h"
#include "core/dom/ElementTraversal.h"
#include "core/dom/StyleChangeReason.h"
+#include "core/dom/TaskRunnerHelper.h"
#include "core/dom/shadow/ElementShadow.h"
#include "core/dom/shadow/ShadowRoot.h"
#include "core/events/Event.h"
@@ -46,12 +47,6 @@
namespace blink {
-static SVGUseEventSender& svgUseLoadEventSender()
-{
- DEFINE_STATIC_LOCAL(SVGUseEventSender, sharedLoadEventSender,
(SVGUseEventSender::create(EventTypeNames::load)));
- return sharedLoadEventSender;
-}
-
inline SVGUseElement::SVGUseElement(Document& document)
: SVGGraphicsElement(SVGNames::useTag, document)
, SVGURIReference(this)
@@ -688,9 +683,8 @@ FloatRect SVGUseElement::getBBox()
return bbox;
}
-void SVGUseElement::dispatchPendingEvent(SVGUseEventSender* eventSender)
+void SVGUseElement::dispatchPendingEvent()
{
- ASSERT_UNUSED(eventSender, eventSender == &svgUseLoadEventSender());
ASSERT(isStructurallyExternal() && m_haveFiredLoadEvent);
dispatchEvent(Event::create(EventTypeNames::load));
}
@@ -711,7 +705,7 @@ void SVGUseElement::notifyFinished(Resource* resource)
return;
ASSERT(!m_haveFiredLoadEvent);
m_haveFiredLoadEvent = true;
- svgUseLoadEventSender().dispatchEventSoon(this);
+ TaskRunnerHelper::get(TaskType::DOMManipulation,
&document())->postTask(BLINK_FROM_HERE,
WTF::bind(&SVGUseElement::dispatchPendingEvent, wrapPersistent(this)));
}
}
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com Link to the patchset: https://codereview.chromium.org/2095253002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove EventSender from SVGUseElement BUG=624697 ========== to ========== Remove EventSender from SVGUseElement BUG=624697 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Remove EventSender from SVGUseElement BUG=624697 ========== to ========== Remove EventSender from SVGUseElement BUG=624697 Committed: https://crrev.com/79dc95f170313734d2e0e61733e7064bb34f0c6b Cr-Commit-Position: refs/heads/master@{#422375} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/79dc95f170313734d2e0e61733e7064bb34f0c6b Cr-Commit-Position: refs/heads/master@{#422375} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
