Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2095243002: Remove EventSender from SVGStyleElement (Closed)

Created:
4 years, 5 months ago by hiroshige
Modified:
4 years, 2 months ago
Reviewers:
fs
CC:
fs, blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove EventSender from SVGStyleElement BUG=624697 Committed: https://crrev.com/637dbfc42bf553b2e40b6090e25ec00a339979e4 Cr-Commit-Position: refs/heads/master@{#422086}

Patch Set 1 #

Patch Set 2 : Use DOMManipulation #

Patch Set 3 : include fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M third_party/WebKit/Source/core/svg/SVGStyleElement.h View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGStyleElement.cpp View 1 2 2 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095243002/1
4 years, 5 months ago (2016-06-26 12:28:15 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-26 14:15:26 UTC) #4
hiroshige
Could you take a look?
4 years, 2 months ago (2016-09-30 07:49:39 UTC) #7
fs
lgtm
4 years, 2 months ago (2016-09-30 08:10:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095243002/40001
4 years, 2 months ago (2016-09-30 11:42:35 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-30 12:17:42 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 12:19:14 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/637dbfc42bf553b2e40b6090e25ec00a339979e4
Cr-Commit-Position: refs/heads/master@{#422086}

Powered by Google App Engine
This is Rietveld 408576698