Refactor notification operation functionality out of PNS

chrome/browser/notifications/notification_operation_common.h

Index: chrome/browser/notifications/notification_operation_common.h
diff --git a/chrome/browser/notifications/notification_operation_common.h b/chrome/browser/notifications/notification_operation_common.h
new file mode 100644
index 0000000000000000000000000000000000000000..9e8261ebf67818e8d6607f3b436236abf429bb26
--- /dev/null
+++ b/chrome/browser/notifications/notification_operation_common.h
@@ -0,0 +1,27 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_OPERATION_COMMON_H_
+#define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_OPERATION_COMMON_H_
+
+// A series of common operations for both in page and persistent notification

[Peter Beverloo, 2016/06/28 22:52:41]

Remove. (A class-level comment would be appropriate. Due to the missing
whitespace this now looks like it applies to the BrowserContext
forward-declaration.)

[Miguel Garcia, 2016/06/29 17:25:40]

Acknowledged.

+namespace content {
+class BrowserContext;
+}  // namespace content
+
+namespace notification_operation_common {

[Peter Beverloo, 2016/06/28 22:52:41]

Please stash common behaviour like this in a class rather than in a namespace.
The former is *much* more common throughout Chromium, and it's beneficial to
maintain consistency. (Mac UI code seems to be a common exception.)

[Miguel Garcia, 2016/06/29 17:25:40]

Done.

+
+// Things you can do to a notification.
+enum NotificationOperation {
+  NOTIFICATION_CLICK = 0,
+  NOTIFICATION_CLOSE = 1,
+  NOTIFICATION_SETTINGS = 2
+};
+
+// Open the Notification settings screen when clicking the right button.
+void OpenNotificationSettings(content::BrowserContext* browser_context);

[Peter Beverloo, 2016/06/28 22:52:41]

This should probably take a Profile* since it's not a //content-called function.
OK to do later, but please add a TODO.

[Miguel Garcia, 2016/06/29 17:25:40]

Todo added but why exactly do we take a BrowserContext in
NotificationObjectProxy? That's the only reason why this is a browser context
and not a profile.

+
+}  // namespace notification_operation_common
+
+#endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_OPERATION_COMMON_H_