Send synthetic GestureTapDown to focus BrowserPlugin

Send synthetic GestureTapDown to focus BrowserPlugin

Since we now route Gesture events directly to the guest renderer, there
is no longer any event to focus the BrowserPlugin in the embedder
renderer, meaning that even though touch/gesture events work properly,
the guest may not receive keyboard input.

This CL provides a temporary fix by sending a synthetic GestureTapDown
to the embedder on TouchStarti, in parallel with sending the TouchStart
directly to the guest. The synthetic event focuses the BrowserPlugin.

This CL also fixes two tests that were still sending 
Gestures to the embedder.

When BrowserPlugin is removed, this code will disappear along with
RenderWidgetHostViewGuest.

BUG=619906
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

[wjmaclean, 2016-06-24 22:08:37]

Description was changed from

==========
Send synthetic GestureTapDown to focus BrowserPlugin

Since we now route Gesture events directly to the guest renderer, there
is no longer any event to focus the BrowserPlugin in the embedder
renderer, meaning that even though touch/gesture events work properly,
the guest may not receive keyboard input.

This CL provides a temporary fix by sending a synthetic GestureTapDown
to the embedder on TouchStarti, in parallel with sending the TouchStart
directly to the guest. The synthetic event focuses the BrowserPlugin.

When BrowserPlugin is removed, this code will disappear along with
RenderWidgetHostViewGuest.

BUG=619906
==========

to

==========
Send synthetic GestureTapDown to focus BrowserPlugin

Since we now route Gesture events directly to the guest renderer, there
is no longer any event to focus the BrowserPlugin in the embedder
renderer, meaning that even though touch/gesture events work properly,
the guest may not receive keyboard input.

This CL provides a temporary fix by sending a synthetic GestureTapDown
to the embedder on TouchStarti, in parallel with sending the TouchStart
directly to the guest. The synthetic event focuses the BrowserPlugin.

When BrowserPlugin is removed, this code will disappear along with
RenderWidgetHostViewGuest.

BUG=619906
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[wjmaclean, 2016-06-27 15:42:02]

Description was changed from

==========
Send synthetic GestureTapDown to focus BrowserPlugin

Since we now route Gesture events directly to the guest renderer, there
is no longer any event to focus the BrowserPlugin in the embedder
renderer, meaning that even though touch/gesture events work properly,
the guest may not receive keyboard input.

This CL provides a temporary fix by sending a synthetic GestureTapDown
to the embedder on TouchStarti, in parallel with sending the TouchStart
directly to the guest. The synthetic event focuses the BrowserPlugin.

When BrowserPlugin is removed, this code will disappear along with
RenderWidgetHostViewGuest.

BUG=619906
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Send synthetic GestureTapDown to focus BrowserPlugin

Since we now route Gesture events directly to the guest renderer, there
is no longer any event to focus the BrowserPlugin in the embedder
renderer, meaning that even though touch/gesture events work properly,
the guest may not receive keyboard input.

This CL provides a temporary fix by sending a synthetic GestureTapDown
to the embedder on TouchStarti, in parallel with sending the TouchStart
directly to the guest. The synthetic event focuses the BrowserPlugin.

This CL also fixes two tests that were still sending 
Gestures to the embedder.

When BrowserPlugin is removed, this code will disappear along with
RenderWidgetHostViewGuest.

BUG=619906
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[wjmaclean, 2016-06-27 15:42:18]

wjmaclean@chromium.org changed reviewers:
+ creis@chromium.org, tdresser@chromium.org

[wjmaclean, 2016-06-27 15:42:29]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 15:42:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 15:42:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 15:42:53]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[wjmaclean, 2016-06-27 15:44:26]

creis@ - small CL, please take a look? This is to fix a regression that
unfortunately made it to stable.

tdresser@ - I just wanted to verify with you that it's OK to send a lone
GestureTapDown (it seems to be). If not, we can send a more complete sequence.

[wjmaclean, 2016-06-27 16:47:48]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 16:48:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 16:48:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 16:48:09]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[wjmaclean, 2016-06-27 17:14:16]

On 2016/06/27 16:48:09, commit-bot: I haz the power wrote:
> Dry run: CLs for remote refs other than refs/pending/heads/master must contain
> NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

I've re-uploaded this at https://codereview.chromium.org/2101663002 to avoid the
CQ dry-run problem.

[tdresser, 2016-06-28 14:22:36]

I'm holding off on review until you've fixed the source of flake.

[wjmaclean, 2016-06-28 18:19:13]

On 2016/06/28 14:22:36, tdresser wrote:
> I'm holding off on review until you've fixed the source of flake.

I've closed this issue, and moved discussion over to
https://codereview.chromium.org/2101663002/ since this issue was originally
created off the master branch, and thus not eligible for dry-runs etc.