Add GN split_list function

Add GN split_list function.

This function splits a list into N sub-lists. The plan is to use this in a template to automatically split static libraries.

Add a new class ParseNodeValueAdapter which allows getting a list out of a function call without having to copy it. This is used in the new code and is used in a cleanup of rebase_foreach (both of which can take large input lists).

Committed: https://crrev.com/c0ff88647c120f24203e50f7886f8e01a163c511
Cr-Commit-Position: refs/heads/master@{#402555}

[brettw, 2016-06-27 20:26:41]

Description was changed from

==========
Add GN split_list function
BUG=
==========

to

==========
Add GN split_list function.

This function splits a list into N sub-lists. The plan is to use this in a
template to automatically split static libraries.

Add a new class ParseNodeValueAdapter which allows getting a list out of a
function call without having to copy it. This is used in the new code and is
used in a cleanup of rebase_path (both of which can take large input lists).
==========

[brettw, 2016-06-27 21:26:33]

.

[brettw, 2016-06-27 21:27:33]

Description was changed from

==========
Add GN split_list function.

This function splits a list into N sub-lists. The plan is to use this in a
template to automatically split static libraries.

Add a new class ParseNodeValueAdapter which allows getting a list out of a
function call without having to copy it. This is used in the new code and is
used in a cleanup of rebase_path (both of which can take large input lists).
==========

to

==========
Add GN split_list function.

This function splits a list into N sub-lists. The plan is to use this in a
template to automatically split static libraries.

Add a new class ParseNodeValueAdapter which allows getting a list out of a
function call without having to copy it. This is used in the new code and is
used in a cleanup of rebase_foreach (both of which can take large input lists).
==========

[brettw, 2016-06-27 21:28:15]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[brettw, 2016-06-27 21:28:20]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 21:29:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-06-27 22:06:02]

https://codereview.chromium.org/2095043005/diff/40001/tools/gn/functions.cc
File tools/gn/functions.cc (right):

https://codereview.chromium.org/2095043005/diff/40001/tools/gn/functions.cc#n...
tools/gn/functions.cc:863: *err = Err(function, "Negative result size.");
<= isn't quite negative, maybe "Should be greater than zero." or something.

https://codereview.chromium.org/2095043005/diff/40001/tools/gn/functions.cc#n...
tools/gn/functions.cc:878: : begin_add + items_per_result;
This doesn't seem quite right. e.g. if there's 6 items into 4 lists, I think
you'll end up with

  [[1, 2], [3, 4], [5, 6], []]

rather than

  [[1, 2], [3, 4], [5], [6]]

.

https://codereview.chromium.org/2095043005/diff/40001/tools/gn/parse_node_val...
File tools/gn/parse_node_value_adapter.h (right):

https://codereview.chromium.org/2095043005/diff/40001/tools/gn/parse_node_val...
tools/gn/parse_node_value_adapter.h:17: // are very large (lsits of many strings
for example).
lists

[commit-bot: I haz the power, 2016-06-27 23:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 23:04:03]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-06-28 18:27:56]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-06-28 18:27:57]

review_comments

[brettw, 2016-06-28 18:28:20]

New algorithm fixes the problem and is very easy to follow.

[commit-bot: I haz the power, 2016-06-28 18:28:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-06-28 18:32:44]

lgtm

https://codereview.chromium.org/2095043005/diff/60001/tools/gn/parse_node_val...
File tools/gn/parse_node_value_adapter.h (right):

https://codereview.chromium.org/2095043005/diff/60001/tools/gn/parse_node_val...
tools/gn/parse_node_value_adapter.h:17: // are very large (lits of many strings
for example).
this got worse :)

[brettw, 2016-06-28 20:00:53]

typo

[brettw, 2016-06-28 20:00:54]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-06-28 20:00:54]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2095043005/#ps80001
(title: "typo")

[commit-bot: I haz the power, 2016-06-28 20:02:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 20:08:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 20:08:54]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[brettw, 2016-06-28 20:23:23]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-06-28 20:24:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 21:41:26]

Description was changed from

==========
Add GN split_list function.

This function splits a list into N sub-lists. The plan is to use this in a
template to automatically split static libraries.

Add a new class ParseNodeValueAdapter which allows getting a list out of a
function call without having to copy it. This is used in the new code and is
used in a cleanup of rebase_foreach (both of which can take large input lists).
==========

to

==========
Add GN split_list function.

This function splits a list into N sub-lists. The plan is to use this in a
template to automatically split static libraries.

Add a new class ParseNodeValueAdapter which allows getting a list out of a
function call without having to copy it. This is used in the new code and is
used in a cleanup of rebase_foreach (both of which can take large input lists).
==========

[commit-bot: I haz the power, 2016-06-28 21:41:27]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-28 21:44:41]

Description was changed from

==========
Add GN split_list function.

This function splits a list into N sub-lists. The plan is to use this in a
template to automatically split static libraries.

Add a new class ParseNodeValueAdapter which allows getting a list out of a
function call without having to copy it. This is used in the new code and is
used in a cleanup of rebase_foreach (both of which can take large input lists).
==========

to

==========
Add GN split_list function.

This function splits a list into N sub-lists. The plan is to use this in a
template to automatically split static libraries.

Add a new class ParseNodeValueAdapter which allows getting a list out of a
function call without having to copy it. This is used in the new code and is
used in a cleanup of rebase_foreach (both of which can take large input lists).

Committed: https://crrev.com/c0ff88647c120f24203e50f7886f8e01a163c511
Cr-Commit-Position: refs/heads/master@{#402555}
==========

[commit-bot: I haz the power, 2016-06-28 21:44:42]

Patchset 5 (id:??) landed as
https://crrev.com/c0ff88647c120f24203e50f7886f8e01a163c511
Cr-Commit-Position: refs/heads/master@{#402555}