Source/core/css/parser/MediaQueryTokenizer.h - Issue 209503003: Convert MediaQueryTokenizer's codepoints array to be static data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/MediaQueryTokenizer.h

Issue 209503003: Convert MediaQueryTokenizer's codepoints array to be static data (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix review nits Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/build/scripts/make_mediaquery_tokenizer_codepoints.py ('K') | « Source/core/core_generated.gyp ('k') | Source/core/css/parser/MediaQueryTokenizer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/MediaQueryTokenizer.h

diff --git a/Source/core/css/parser/MediaQueryTokenizer.h b/Source/core/css/parser/MediaQueryTokenizer.h

index 73df890b0de18ebc56b12cd962ae9e411e359f30..850cb050cfc2f023d43c146ba90bb318f3f13bff 100644

--- a/Source/core/css/parser/MediaQueryTokenizer.h

+++ b/Source/core/css/parser/MediaQueryTokenizer.h

@@ -20,10 +20,7 @@ class MediaQueryTokenizer {

WTF_MAKE_FAST_ALLOCATED;

public:

static void tokenize(String, Vector<MediaQueryToken>&);

private:

- class CodePoints;

MediaQueryTokenizer(MediaQueryInputStream&);

MediaQueryToken nextToken();

@@ -48,6 +45,8 @@ private:

typedef MediaQueryToken (MediaQueryTokenizer::*CodePoint)(UChar);

+ static const CodePoint codePoints[];

MediaQueryToken whiteSpace(UChar);

MediaQueryToken leftParenthesis(UChar);

MediaQueryToken rightParenthesis(UChar);

@@ -62,8 +61,6 @@ private:

MediaQueryToken nameStart(UChar);

MediaQueryToken endOfFile(UChar);

- CodePoints* codePoints();

MediaQueryInputStream& m_input;

};