Changes in DisplayItemClient for spv2 paint invalidation

third_party/WebKit/Source/web/PageOverlay.h

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 60 matching lines @@
     LayoutRect visualRect() const override;
 
     // GraphicsLayerClient implementation
     bool needsRepaint(const GraphicsLayer&) const { return true; }
     IntRect computeInterestRect(const GraphicsLayer*, const IntRect&) const override;
     void paintContents(const GraphicsLayer*, GraphicsContext&, GraphicsLayerPaintingPhase, const IntRect& interestRect) const override;
     String debugName(const GraphicsLayer*) const override;
 
 private:
     PageOverlay(WebViewImpl*, PageOverlay::Delegate*);
-    DISPLAY_ITEM_CACHE_STATUS_UNCACHEABLE_IMPLEMENTATION

[chrishtr, 2016/06/27 21:09:09]

I don't understand yet how the uncacheable implementations still work with this
patch. Could you explain?

[Xianzhu, 2016/06/27 21:34:54]

Previously we used the uncacheable implementation for DisplayItemClients that
caching doesn't make much sense. Caching is still not important for them, but
now they may be cached if possible, but normally caching doesn't apply in the
contexts (e.g. caching is skipped or we always paint on a fresh
PaintController).

 
     WebViewImpl* m_viewImpl;
     Persistent<PageOverlay::Delegate> m_delegate;
     std::unique_ptr<GraphicsLayer> m_layer;
 };
 
 } // namespace blink
 
 #endif // PageOverlay_h