Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 2095013002: [Android] Fix feature annotation filtering for instrumentation tests. (Closed)

Created:
4 years, 6 months ago by jbudorick
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix feature annotation filtering for instrumentation tests. BUG=623009 Committed: https://crrev.com/cd81a621b7de946bc910405de15a80fd95bc3b88 Cr-Commit-Position: refs/heads/master@{#401872}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -4 lines) Patch
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 chunk +13 lines, -3 lines 2 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance_test.py View 2 chunks +416 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
4 years, 6 months ago (2016-06-24 13:17:40 UTC) #2
rnephew (Reviews Here)
lgtm with one possible suggestion that isn't that important. https://codereview.chromium.org/2095013002/diff/1/build/android/pylib/instrumentation/instrumentation_test_instance.py File build/android/pylib/instrumentation/instrumentation_test_instance.py (right): https://codereview.chromium.org/2095013002/diff/1/build/android/pylib/instrumentation/instrumentation_test_instance.py#newcode593 build/android/pylib/instrumentation/instrumentation_test_instance.py:593: ...
4 years, 6 months ago (2016-06-24 14:22:44 UTC) #3
jbudorick
https://codereview.chromium.org/2095013002/diff/1/build/android/pylib/instrumentation/instrumentation_test_instance.py File build/android/pylib/instrumentation/instrumentation_test_instance.py (right): https://codereview.chromium.org/2095013002/diff/1/build/android/pylib/instrumentation/instrumentation_test_instance.py#newcode593 build/android/pylib/instrumentation/instrumentation_test_instance.py:593: ak in all_annotations On 2016/06/24 14:22:43, rnephew (Reviews Here) ...
4 years, 6 months ago (2016-06-24 14:24:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095013002/1
4 years, 6 months ago (2016-06-24 14:26:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 16:21:52 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 16:23:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd81a621b7de946bc910405de15a80fd95bc3b88
Cr-Commit-Position: refs/heads/master@{#401872}

Powered by Google App Engine
This is Rietveld 408576698