Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/browser/tab_contents/navigation_entry.h

Issue 2095006: Revert 47347 - (Original patch reviewed at http://codereview.chromium.org/206... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/ssl_policy_backend.cc ('k') | chrome/browser/tab_contents/navigation_entry_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/navigation_entry.h
===================================================================
--- chrome/browser/tab_contents/navigation_entry.h (revision 47356)
+++ chrome/browser/tab_contents/navigation_entry.h (working copy)
@@ -37,17 +37,8 @@
public:
// Flags used for the page security content status.
enum ContentStatusFlags {
- // HTTP page, or HTTPS page with no insecure content.
- NORMAL_CONTENT = 0,
-
- // HTTPS page containing "displayed" HTTP resources (e.g. images, CSS).
- DISPLAYED_MIXED_CONTENT = 1 << 0,
-
- // HTTPS page containing "executed" HTTP resources (i.e. script).
- // Also currently used for HTTPS page containing broken-HTTPS resources;
- // this is wrong and should be fixed (see comments in
- // SSLPolicy::OnRequestStarted()).
- RAN_MIXED_CONTENT = 1 << 1,
+ NORMAL_CONTENT = 0, // No mixed content.
+ MIXED_CONTENT = 1 << 0, // https page containing http resources.
};
SSLStatus();
@@ -88,20 +79,15 @@
return security_bits_;
}
- void set_displayed_mixed_content() {
- content_status_ |= DISPLAYED_MIXED_CONTENT;
+ // Mixed content means that this page which is served over https contains
+ // http sub-resources.
+ void set_has_mixed_content() {
+ content_status_ |= MIXED_CONTENT;
}
- bool displayed_mixed_content() const {
- return (content_status_ & DISPLAYED_MIXED_CONTENT) != 0;
+ bool has_mixed_content() const {
+ return (content_status_ & MIXED_CONTENT) != 0;
}
- void set_ran_mixed_content() {
- content_status_ |= RAN_MIXED_CONTENT;
- }
- bool ran_mixed_content() const {
- return (content_status_ & RAN_MIXED_CONTENT) != 0;
- }
-
// Raw accessors for all the content status flags. This contains a
// combination of any of the ContentStatusFlags defined above. It is used
// by some tests for checking and for certain copying. Use the per-status
« no previous file with comments | « chrome/browser/ssl/ssl_policy_backend.cc ('k') | chrome/browser/tab_contents/navigation_entry_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698