Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2095003003: [compiler] Fix turbofan string allocation (Closed)

Created:
4 years, 6 months ago by john.yan
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Fix turbofan string allocation The hash field is supposed to be 4 bytes even in 64-bit. But the default parameter of StoreObjectFieldNoWriteBarrier using kTagged will generate 64-bit store. Fix by Replacing kTagged with kWord32. This causes ~200 test failures on big-endian, because hash field offset in BE is 12 instead of 8 in LE platforms. R=bmeurer@chromium.org, epertoso@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/fa5e0490554963720338a13afc1001f32815f94c Cr-Commit-Position: refs/heads/master@{#37256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/code-stub-assembler.cc View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095003003/1
4 years, 6 months ago (2016-06-24 14:49:59 UTC) #2
john.yan
PTAL.
4 years, 6 months ago (2016-06-24 14:55:55 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 15:14:14 UTC) #5
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-24 18:23:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095003003/1
4 years, 6 months ago (2016-06-24 18:23:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 18:25:53 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fa5e0490554963720338a13afc1001f32815f94c Cr-Commit-Position: refs/heads/master@{#37256}
4 years, 6 months ago (2016-06-24 18:26:15 UTC) #11
Benedikt Meurer
4 years, 6 months ago (2016-06-24 18:27:16 UTC) #12
Message was sent while issue was closed.
Thanks a lot for the fix.

Powered by Google App Engine
This is Rietveld 408576698