Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 2094973002: Completely clear weak persistent references. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Completely clear weak persistent references. If weak processing determines that a WeakPersistent<T> is now pointing to an otherwise unreferenced object, clear out and deallocate its underlying PersistentNode. We previously would only clear the persistent reference, but keep the PersistentNode. This would lead to imprecise counts of live persistents, potentially triggering false asserts of leaking persistents during thread termination GCs. R= BUG= Committed: https://crrev.com/0508bde56b8a90655708fbd89418650f828ee546 Cr-Commit-Position: refs/heads/master@{#401880}

Patch Set 1 #

Patch Set 2 : tidy #

Patch Set 3 : fix registerWeakMembers() invocation #

Patch Set 4 : undo strongification.. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M third_party/WebKit/Source/platform/heap/Persistent.h View 1 2 3 3 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 6 months ago (2016-06-24 14:09:13 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-24 14:32:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094973002/60001
4 years, 6 months ago (2016-06-24 14:37:54 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-24 16:35:28 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 16:37:20 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0508bde56b8a90655708fbd89418650f828ee546
Cr-Commit-Position: refs/heads/master@{#401880}

Powered by Google App Engine
This is Rietveld 408576698