Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2094953002: X87: [builtins] Introduce proper Float64Log1p operator. (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Introduce proper Float64Log1p operator. port 7ceed92ac036d6b4e402d76a5cea130a3c4cfbf1 (r36914) original commit message: Import base::ieee754::log1p() from fdlibm and introduce a Float64Log1p TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.log1p() as TurboFan builtin and use that operator to also inline Math.log1p() into optimized TurboFan functions. Also unify the handling of the special IEEE 754 functions somewhat in the TurboFan backends. At some point we can hopefully express this completely in the InstructionSelector (once we have an idea what to do with the ST(0) return issue on IA-32/X87). BUG= Drive-by-fix: Add some more test coverage for the log function. Committed: https://crrev.com/196a0d3a64fe8f3ccc547e183b782c15076dce83 Cr-Commit-Position: refs/heads/master@{#37255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -24 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +25 lines, -17 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-24 10:44:34 UTC) #2
Weiliang
lgtm
4 years, 6 months ago (2016-06-24 13:00:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094953002/1
4 years, 6 months ago (2016-06-24 15:00:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 15:23:08 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 15:24:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/196a0d3a64fe8f3ccc547e183b782c15076dce83
Cr-Commit-Position: refs/heads/master@{#37255}

Powered by Google App Engine
This is Rietveld 408576698