chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java - Issue 2094903003: Pass all intent extras needed to render splash screen when launching WebAPK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

Issue 2094903003: Pass all intent extras needed to render splash screen when launching WebAPK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_more_meta Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java ('k') | chrome/android/webapk/shell_apk/AndroidManifest.xml » ('j') | chrome/android/webapk/shell_apk/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

diff --git a/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java b/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

index df53f08564889883eeb81ebe6d6debe2c401f20e..ee0b1237fc950e03e4757c53fd7a2719514f12e6 100644

--- a/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

+++ b/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

@@ -12,4 +12,8 @@ public final class WebApkConstants {

// WebAPK id prefix. The id is used for storing WebAPK data in Chrome's SharedPreferences.

public static final String WEBAPK_ID_PREFIX = "webapk:";

+ // Used for sending Android Manifest properties to WebappLauncherActivity.

+ public static final String EXTRA_DISPLAY_MODE = "org.chromium.webapk.lib.common.display_mode";

dominickn 2016/06/28 05:26:55 Can we replace the EXTRA_ prefix? I can see potent

pkotwicz 2016/06/28 17:56:21 Ok renamed to EXTRA_WEBAPK_DISPLAY_MODE

+ public static final String EXTRA_ORIENTATION = "org.chromium.webapk.lib.common.orientation";

}