Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Issue 2094903002: [Devtools] Fixed websocket initiators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed initiators for websockets Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
index 31a9361ad76df2c9c4d11df5a99457d277fcd189..1e1c1154ca96ae5ab38e8b0ec281451f4b314afc 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
@@ -819,9 +819,15 @@ std::unique_ptr<protocol::Network::Initiator> InspectorNetworkAgent::buildInitia
.setType(protocol::Network::Initiator::TypeEnum::Other).build();
}
-void InspectorNetworkAgent::didCreateWebSocket(Document*, unsigned long identifier, const KURL& requestURL, const String&)
+void InspectorNetworkAgent::didCreateWebSocket(Document* document, unsigned long identifier, const KURL& requestURL, const String&)
{
- frontend()->webSocketCreated(IdentifiersFactory::requestId(identifier), urlWithoutFragment(requestURL).getString());
+ std::unique_ptr<protocol::Runtime::StackTrace> currentStackTrace = SourceLocation::capture(document)->buildInspectorObject();
+ DCHECK(currentStackTrace);
dgozman 2016/06/24 20:21:03 This DCHECK looks suspicious. What if websocket wa
+ std::unique_ptr<protocol::Network::Initiator> initiatorObject = protocol::Network::Initiator::create()
+ .setType(protocol::Network::Initiator::TypeEnum::Script).build();
+ initiatorObject->setStack(std::move(currentStackTrace));
+
+ frontend()->webSocketCreated(IdentifiersFactory::requestId(identifier), urlWithoutFragment(requestURL).getString(), std::move(initiatorObject));
}
void InspectorNetworkAgent::willSendWebSocketHandshakeRequest(Document*, unsigned long identifier, const WebSocketHandshakeRequest* request)

Powered by Google App Engine
This is Rietveld 408576698