Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Issue 2094903002: [Devtools] Fixed websocket initiators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed initiators for websockets Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 438 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 } 449 }
450 } 450 }
451 networkRequest.localizedFailDescription = localizedDescription; 451 networkRequest.localizedFailDescription = localizedDescription;
452 this._finishNetworkRequest(networkRequest, time, -1); 452 this._finishNetworkRequest(networkRequest, time, -1);
453 }, 453 },
454 454
455 /** 455 /**
456 * @override 456 * @override
457 * @param {!NetworkAgent.RequestId} requestId 457 * @param {!NetworkAgent.RequestId} requestId
458 * @param {string} requestURL 458 * @param {string} requestURL
459 * @param {!NetworkAgent.Initiator=} initiator
459 */ 460 */
460 webSocketCreated: function(requestId, requestURL) 461 webSocketCreated: function(requestId, requestURL, initiator)
461 { 462 {
462 // FIXME: WebSocket MUST have initiator info. 463 var networkRequest = new WebInspector.NetworkRequest(this._manager._targ et, requestId, requestURL, "", "", "", initiator ? initiator : null);
dgozman 2016/06/27 19:14:50 nit: initiator || null
allada 2016/06/29 18:15:12 Done.
463 var networkRequest = new WebInspector.NetworkRequest(this._manager._targ et, requestId, requestURL, "", "", "", null);
464 networkRequest.setResourceType(WebInspector.resourceTypes.WebSocket); 464 networkRequest.setResourceType(WebInspector.resourceTypes.WebSocket);
465 this._startNetworkRequest(networkRequest); 465 this._startNetworkRequest(networkRequest);
466 }, 466 },
467 467
468 /** 468 /**
469 * @override 469 * @override
470 * @param {!NetworkAgent.RequestId} requestId 470 * @param {!NetworkAgent.RequestId} requestId
471 * @param {!NetworkAgent.Timestamp} time 471 * @param {!NetworkAgent.Timestamp} time
472 * @param {!NetworkAgent.Timestamp} wallTime 472 * @param {!NetworkAgent.Timestamp} wallTime
473 * @param {!NetworkAgent.WebSocketRequest} request 473 * @param {!NetworkAgent.WebSocketRequest} request
(...skipping 433 matching lines...) Expand 10 before | Expand all | Expand 10 after
907 WebInspector.ResourceLoader.load(url, headers, callback); 907 WebInspector.ResourceLoader.load(url, headers, callback);
908 }, 908 },
909 909
910 __proto__: WebInspector.Object.prototype 910 __proto__: WebInspector.Object.prototype
911 } 911 }
912 912
913 /** 913 /**
914 * @type {!WebInspector.MultitargetNetworkManager} 914 * @type {!WebInspector.MultitargetNetworkManager}
915 */ 915 */
916 WebInspector.multitargetNetworkManager; 916 WebInspector.multitargetNetworkManager;
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698