Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2094873003: Make base::WeakPtr moveable. (Closed)

Created:
4 years, 5 months ago by Marijn Kruisselbrink
Modified:
4 years, 5 months ago
Reviewers:
danakj
CC:
chromium-reviews, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make base::WeakPtr moveable. Committed: https://crrev.com/79016817023e0ef37567e9159e04691545124b39 Cr-Commit-Position: refs/heads/master@{#401977}

Patch Set 1 #

Total comments: 2

Patch Set 2 : std::move WeakPtrBase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M base/memory/weak_ptr.h View 1 3 chunks +14 lines, -2 lines 0 comments Download
M base/memory/weak_ptr.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M base/memory/weak_ptr_unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Marijn Kruisselbrink
4 years, 5 months ago (2016-06-24 00:00:32 UTC) #4
vmpstr
https://codereview.chromium.org/2094873003/diff/40001/base/memory/weak_ptr.h File base/memory/weak_ptr.h (right): https://codereview.chromium.org/2094873003/diff/40001/base/memory/weak_ptr.h#newcode222 base/memory/weak_ptr.h:222: WeakPtr(WeakPtr<U>&& other) : WeakPtrBase(other), ptr_(other.ptr_) { WeakPtrBase(std::move(other))
4 years, 5 months ago (2016-06-24 00:17:39 UTC) #5
Marijn Kruisselbrink
https://codereview.chromium.org/2094873003/diff/40001/base/memory/weak_ptr.h File base/memory/weak_ptr.h (right): https://codereview.chromium.org/2094873003/diff/40001/base/memory/weak_ptr.h#newcode222 base/memory/weak_ptr.h:222: WeakPtr(WeakPtr<U>&& other) : WeakPtrBase(other), ptr_(other.ptr_) { On 2016/06/24 at ...
4 years, 5 months ago (2016-06-24 00:50:15 UTC) #6
danakj
LGTM
4 years, 5 months ago (2016-06-24 19:35:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094873003/60001
4 years, 5 months ago (2016-06-24 19:40:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 5 months ago (2016-06-24 21:29:25 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-24 21:30:35 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/79016817023e0ef37567e9159e04691545124b39
Cr-Commit-Position: refs/heads/master@{#401977}

Powered by Google App Engine
This is Rietveld 408576698