third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js - Issue 2094873002: DevTools: fix deepActiveElement and focus on Dialog when document blurs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js

Issue 2094873002: DevTools: fix deepActiveElement and focus on Dialog when document blurs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/Dialog.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/Dialog.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js

diff --git a/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js b/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js

index 3e18f62839b954f3bf30dd762d2b052729a0b60b..ddfdcf4ab11737e2f6ad6d9373b56d53fbc86c6d 100644

--- a/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js

+++ b/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js

@@ -28,11 +28,13 @@ WebInspector.FrameworkBlackboxSettingsTab = function()

placeholder.textContent = WebInspector.UIString("No blackboxed patterns");

this._list.setEmptyPlaceholder(placeholder);

this._list.show(this.contentElement);

- this.contentElement.appendChild(createTextButton(WebInspector.UIString("Add pattern..."), this._addButtonClicked.bind(this), "add-button"));

+ var addPatternButton = createTextButton(WebInspector.UIString("Add pattern..."), this._addButtonClicked.bind(this), "add-button");

+ this.contentElement.appendChild(addPatternButton);

this._setting = WebInspector.moduleSetting("skipStackFramesPattern");

this._setting.addChangeListener(this._settingUpdated, this);

+ this.setDefaultFocusedElement(addPatternButton);

this.contentElement.tabIndex = 0;

}