third_party/WebKit/Source/devtools/front_end/ui/Dialog.js - Issue 2094873002: DevTools: fix deepActiveElement and focus on Dialog when document blurs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

Issue 2094873002: DevTools: fix deepActiveElement and focus on Dialog when document blurs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Re-added buttons as default elements and fix deepActiveElement and dialog focus Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js b/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

index a15b39a0ccea3dff0f1e678ed7805db4dbfe87d2..ea802e7262d229e5ac74b1919a90fcd7454bac06 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

@@ -50,7 +50,6 @@ WebInspector.Dialog = function()

}

/**

- * TODO(dgozman): remove this method (it's only used for shortcuts handling).

* @return {boolean}

WebInspector.Dialog.hasInstance = function()

@@ -58,6 +57,12 @@ WebInspector.Dialog.hasInstance = function()

return !!WebInspector.Dialog._instance;

}

+WebInspector.Dialog.focus = function()

+ if (WebInspector.Dialog._instance)

+ WebInspector.Dialog._instance.focus();

WebInspector.Dialog.prototype = {

/**

* @override