DevTools: fix deepActiveElement and focus on Dialog when document blurs

third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com).
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
@@ skipping 858 matching lines @@
         if (!WebInspector._isTextEditingElement(x) && selection.isCollapsed && !x.isInsertionCaretInside()) {
             var selectionRange = x.ownerDocument.createRange();
             selectionRange.setStart(x, 0);
             selectionRange.setEnd(x, 0);
 
             selection.removeAllRanges();
             selection.addRange(selectionRange);
         }
     } else if (WebInspector._previousFocusElement)
         WebInspector._previousFocusElement.blur();
+
+    if (!x)
+        WebInspector.Dialog.focus();

[dgozman, 2016/06/29 22:19:15]

I wonder how the dialog is different from document? Why do be respect the blur
on document, but not dialog?

[luoe, 2016/06/30 00:03:16]

When the document is blurred (e.g. clicking on a non-focusable element),
document.activeElement can be == document.body.  So if the body has focus when a
dialog is open and 'Esc' is pressed, Dialog's onKeyDown won't fire and it won't
close.

I don't have a great reason why this is the right way to make sure 'Esc' always
works.  Maybe a better fix is to have Dialogs add an event listener to the
ownerDocument.body, just like how StylesSidebarPane does it.

 }
 
 WebInspector.restoreFocusFromElement = function(element)
 {
     if (element && element.isSelfOrAncestor(WebInspector.currentFocusElement()))
         WebInspector.setCurrentFocusElement(WebInspector.previousFocusElement());
 }
 
 /**
  * @param {!Element} element
@@ skipping 1089 matching lines @@
  * @param {string} title
  * @return {!Element}
  */
 WebInspector.linkifyDocumentationURLAsNode = function(article, title)
 {
     return WebInspector.linkifyURLAsNode("https://developers.google.com/web/tools/chrome-devtools/" + article, title, undefined, true);
 }
 
 /** @type {!WebInspector.ThemeSupport} */
 WebInspector.themeSupport;