DevTools: fix deepActiveElement and focus on Dialog when document blurs

third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @param {function(!Array<!WebInspector.NetworkConditionsGroup>):!Array<?WebInspector.NetworkManager.Conditions>} populateCallback
  * @param {function(number)} selectCallback
  */
 WebInspector.NetworkConditionsSelector = function(populateCallback, selectCallback)
@@ skipping 266 matching lines @@
     this.contentElement.appendChild(addButton);
 
     this._list = new WebInspector.ListWidget(this);
     this._list.element.classList.add("conditions-list");
     this._list.registerRequiredCSS("components/networkConditionsSettingsTab.css");
     this._list.show(this.contentElement);
 
     this._customSetting = WebInspector.moduleSetting("customNetworkConditions");
     this._customSetting.addChangeListener(this._conditionsUpdated, this);
 
     this.setDefaultFocusedElement(addButton);

[dgozman, 2016/06/24 17:53:51]

How does this call interact with new override?

[luoe, 2016/06/24 20:41:53]

Good comment, I think this can be safely removed.

     this.contentElement.tabIndex = 0;
 }
 
 WebInspector.NetworkConditionsSettingsTab.prototype = {
+    /**
+     * @override
+     * @return {!Element}
+     */
+    defaultFocusedElement: function()
+    {
+        return this.contentElement;
+    },
+
     wasShown: function()
     {
         WebInspector.VBox.prototype.wasShown.call(this);
         this._conditionsUpdated();
     },
 
     _conditionsUpdated: function()
     {
         this._list.clear();
 
@@ skipping 189 matching lines @@
             WebInspector.multitargetNetworkManager.setNetworkConditions(WebInspector.NetworkManager.NoThrottlingConditions);
             return true;
         }
         if (actionId === "components.network-offline") {
             WebInspector.multitargetNetworkManager.setNetworkConditions(WebInspector.NetworkManager.OfflineConditions);
             return true;
         }
         return false;
     }
 }