Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2094813003: cc: Merge PictureImageLayerImpl and PictureLayerImpl. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Merge PictureImageLayerImpl and PictureLayerImpl. This patch doesn't change behavior, but it merges image layer impl with plain old picture layer impl. PictureImageLayer still remains, but it creates PictureLayerImpl as its impl counterpart. R=enne, danakj CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/9dab6fe8c9efad6b54303a179595e04b2ab5f749 Cr-Commit-Position: refs/heads/master@{#401791}

Patch Set 1 #

Patch Set 2 : borders #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -297 lines) Patch
M cc/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/cc.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/cc_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/picture_image_layer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
D cc/layers/picture_image_layer_impl.h View 1 chunk +0 lines, -42 lines 0 comments Download
D cc/layers/picture_image_layer_impl.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D cc/layers/picture_image_layer_impl_unittest.cc View 1 chunk +0 lines, -182 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 3 chunks +8 lines, -3 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 6 chunks +33 lines, -3 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
vmpstr
Please take a look. I'm not sure if we want to keep the border colors ...
4 years, 5 months ago (2016-06-23 22:02:22 UTC) #2
enne (OOO)
lgtm I think we could keep the border color, I guess?
4 years, 5 months ago (2016-06-23 22:06:27 UTC) #3
vmpstr
On 2016/06/23 22:06:27, enne wrote: > lgtm > > I think we could keep the ...
4 years, 5 months ago (2016-06-23 23:14:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2094813003/20001
4 years, 5 months ago (2016-06-23 23:14:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-24 02:13:52 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-24 02:16:03 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9dab6fe8c9efad6b54303a179595e04b2ab5f749
Cr-Commit-Position: refs/heads/master@{#401791}

Powered by Google App Engine
This is Rietveld 408576698