Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2461)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 2094813002: MD Settings: make custom UIs look "actionable" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dpapad@ review Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/people_page.html
diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html
index b3c18969757c9e06a1729b5fe7314a285d44c1c7..56dda11a553edd831dc59d6842002eacb1d847c4 100644
--- a/chrome/browser/resources/settings/people_page/people_page.html
+++ b/chrome/browser/resources/settings/people_page/people_page.html
@@ -45,17 +45,11 @@
cursor: pointer;
}
-<if expr="not chromeos">
- #profile-name:hover {
- cursor: pointer;
- }
-</if>
-
#managed-by-domain-name {
font-weight: bold;
}
- iron-icon[icon="settings:sync-problem"] {
+ iron-icon[icon='settings:sync-problem'] {
--iron-icon-fill-color: var(--settings-error-color);
}
@@ -81,14 +75,14 @@
<neon-animatable id="main">
<div class="settings-box first two-line">
<img id="profile-icon" src="[[profileIconUrl_]]"
- on-tap="onPictureTap_">
+ on-tap="onPictureTap_" actionable>
<div class="middle">
-<if expr="chromeos">
- <span id="profile-name" on-tap="onProfileNameTap_">
+<if expr="not chromeos">
+ <span id="profile-name" on-tap="onProfileNameTap_" actionable>
[[profileName_]]
</span>
</if>
-<if expr="not chromeos">
+<if expr="chromeos">
<span id="profile-name">
[[profileName_]]
</span>
@@ -132,7 +126,7 @@
<template is="dom-if"
if="[[isAdvancedSyncSettingsVisible_(syncStatus)]]">
- <div class="settings-box two-line" on-tap="onSyncTap_">
+ <div class="settings-box two-line" on-tap="onSyncTap_" actionable>
<div class="icon-container">
<iron-icon id="sync-icon" icon$="[[getSyncIcon_(syncStatus)]]">
</iron-icon>
@@ -151,7 +145,7 @@
</template>
<div class="settings-box two-line" id="activity-controls"
- on-tap="onActivityControlsTap_">
+ on-tap="onActivityControlsTap_" actionable>
<div class="icon-container">
<div id="googleg-logo"></div>
</div>

Powered by Google App Engine
This is Rietveld 408576698