Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6176)

Unified Diff: chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html

Issue 2094813002: MD Settings: make custom UIs look "actionable" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dpapad@ review Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
diff --git a/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html b/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
index 252ef143591918ef91a7bccaa759b795d86652a7..500c5f9b411764152e7b1d9d9471a0b65a348a96 100644
--- a/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
+++ b/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
@@ -28,7 +28,7 @@
</style>
<template>
<div class="flex layout horizontal center" dropdown$="[[dropdownOpened]]"
- on-tap="itemTapped_">
+ on-tap="itemTapped_" actionable>
<span class="name" connected$="[[device.connected]]">
[[getDeviceName_(device)]]
</span>
@@ -36,11 +36,16 @@
</iron-icon>
<span class="flex"></span>
<span hidden$="[[!device.connecting]]">$i18n{bluetoothConnecting}</span>
+ <!-- This <div on-tap> is not [actionable] because its effect is not user
+ visible. -->
<div hidden$="[[!device.paired]]" on-tap="doNothing_">
<paper-icon-button icon="cr:more-vert" toggles
active="{{dropdownOpened}}">
</paper-icon-button>
- <iron-dropdown opened="{{dropdownOpened}}" on-tap="menuSelected_">
+ <!-- TODO(dbeam): does this need [actionable] if all the controls are
+ paper-items. Conversely, should the on-tap be at this level? -->
+ <iron-dropdown opened="{{dropdownOpened}}" on-tap="menuSelected_"
+ actionable>
<div class="dropdown-content">
<paper-item id="connect" hidden$="[[device.connected]]">
$i18n{bluetoothConnect}

Powered by Google App Engine
This is Rietveld 408576698