Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: chrome/browser/resources/settings/about_page/about_page.html

Issue 2094813002: MD Settings: make custom UIs look "actionable" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dpapad@ review Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/about_page/about_page.html
diff --git a/chrome/browser/resources/settings/about_page/about_page.html b/chrome/browser/resources/settings/about_page/about_page.html
index 8cc7b63396e833f685a5cd2462c2a1d9afa544f2..0354cc6bbb5f9dca17d786cc43aeac3f48be1596 100644
--- a/chrome/browser/resources/settings/about_page/about_page.html
+++ b/chrome/browser/resources/settings/about_page/about_page.html
@@ -26,8 +26,8 @@
<style include="settings-shared settings-page-styles">
.product-title {
font-size: 20px;
- margin-top: auto;
margin-bottom: auto;
+ margin-top: auto;
}
img {
@@ -38,11 +38,11 @@
-webkit-margin-end: var(--iron-icon-spacing);
}
- iron-icon[icon="settings:check-circle"] {
+ iron-icon[icon='settings:check-circle'] {
fill: var(--paper-blue-600);
}
- iron-icon[icon="settings:error"] {
+ iron-icon[icon='settings:error'] {
fill: var(--paper-red-600);
}
@@ -121,17 +121,19 @@
</paper-button>
</if>
</div>
- <div id="help" class="settings-box two-line" on-tap="onHelpTap_">
+ <div id="help" class="settings-box two-line" on-tap="onHelpTap_"
+ actionable>
$i18n{aboutGetHelpUsingChrome}
</div>
<if expr="_google_chrome">
- <div id="reportIssue" class="settings-box"
+ <div id="reportIssue" class="settings-box" actionable
on-tap="onReportIssueTap_">
$i18n{aboutReportAnIssue}
</div>
</if>
<if expr="chromeos">
- <div class="settings-box" on-tap="onDetailedBuildInfoTap_">
+ <div class="settings-box" on-tap="onDetailedBuildInfoTap_"
+ actionable>
<!-- TODO(dpapad): Localize string. -->
Detailed build info
</div>

Powered by Google App Engine
This is Rietveld 408576698