chrome/browser/resources/settings/on_startup_page/startup_urls_page.html - Issue 2094813002: MD Settings: make custom UIs look "actionable"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

Issue 2094813002: MD Settings: make custom UIs look "actionable" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dpapad@ review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/languages_page/languages_page.html ('K') | « chrome/browser/resources/settings/languages_page/languages_page.html ('k') | chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

diff --git a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

index 7ec5f8445afd3d1a394059bfc1851250b0801ed0..594888e9a0c89355b06f80599024b4d05569bd72 100644

--- a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

+++ b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

@@ -17,10 +17,11 @@

<settings-startup-url-entry model="[[item]]">

</settings-startup-url-entry>

</template>

- <div class="list-item list-button" id="addPage" on-tap="onAddPageTap_">

+ <div class="list-item list-button" id="addPage" on-tap="onAddPageTap_"

+ actionable>

$i18n{onStartupAddNewPage}

</div>

- <div class="list-item list-button" id="useCurrentPages"

+ <div class="list-item list-button" id="useCurrentPages" actionable

dpapad 2016/06/23 22:07:46 list-button could also be a good selector for appl

Dan Beam 2016/06/23 23:31:49 Done.

on-tap="onUseCurrentPagesTap_">$i18n{onStartupUseCurrent}</div>

</div>