chrome/browser/resources/settings/settings_main/settings_main.html - Issue 2094813002: MD Settings: make custom UIs look "actionable"

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 2094813002: MD Settings: make custom UIs look "actionable" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dpapad@ review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/languages_page/languages_page.js ('K') | « chrome/browser/resources/settings/reset_page/reset_page.html ('k') | chrome/browser/resources/settings/settings_menu/settings_menu.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html">	1 <link rel="import" href="chrome://resources/cr_elements/icons.html">

2 <link rel="import" href="chrome://resources/html/polymer.html">	2 <link rel="import" href="chrome://resources/html/polymer.html">

3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">	3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">

4 <link rel="import" href="/about_page/about_page.html">	4 <link rel="import" href="/about_page/about_page.html">

5 <link rel="import" href="/advanced_page/advanced_page.html">	5 <link rel="import" href="/advanced_page/advanced_page.html">

6 <link rel="import" href="/basic_page/basic_page.html">	6 <link rel="import" href="/basic_page/basic_page.html">

7 <link rel="import" href="/settings_page/main_page_behavior.html">	7 <link rel="import" href="/settings_page/main_page_behavior.html">

	8 <link rel="import" href="/settings_root_css.html">

8	9

9 <dom-module id="settings-main">	10 <dom-module id="settings-main">

10 <template>	11 <template>

11 <style>	12 <style>

12 #advancedToggle {	13 #advancedToggle {

	14 @apply(--settings-actionable);

13 align-items: center;	15 align-items: center;

14 display: flex;	16 display: flex;

15 margin-bottom: 24px;	17 margin-bottom: 24px;

16 margin-top: 12px; /* Part of a 48px spacer (33px + 12px + 3px). */	18 margin-top: 12px; /* Part of a 48px spacer (33px + 12px + 3px). */

17 min-height: 32px;	19 min-height: 32px;

18 padding: 0 12px;	20 padding: 0 12px;

19 }	21 }

20	22

21 #toggleContainer {	23 #toggleContainer {

22 align-items: center;	24 align-items: center;

(...skipping 29 matching lines...) Expand all Loading...
52 current-route="{{currentRoute}}">	54 current-route="{{currentRoute}}">

53 </settings-advanced-page>	55 </settings-advanced-page>

54 </template>	56 </template>

55 <template is="dom-if" if="[[showAboutPage_]]">	57 <template is="dom-if" if="[[showAboutPage_]]">

56 <settings-about-page current-route="{{currentRoute}}">	58 <settings-about-page current-route="{{currentRoute}}">

57 </settings-about-page>	59 </settings-about-page>

58 </template>	60 </template>

59 </template>	61 </template>

60 <script src="settings_main.js"></script>	62 <script src="settings_main.js"></script>

61 </dom-module>	63 </dom-module>

OLD	NEW