content/browser/compositor/surface_utils.cc - Issue 2094803005: Fix PrepareTextureCopyOutputResult to avoid ScopedCallbackRunner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/surface_utils.cc

Issue 2094803005: Fix PrepareTextureCopyOutputResult to avoid ScopedCallbackRunner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_closure_runner

Patch Set: RunAndReset Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/install_verification/win/module_list_unittest.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/surface_utils.cc

diff --git a/content/browser/compositor/surface_utils.cc b/content/browser/compositor/surface_utils.cc

index e0e49162781b9b649f38fb25a2d5e09d765082b5..4cbd80dfaba4f2b39b2b912799351c9e32a10d41 100644

--- a/content/browser/compositor/surface_utils.cc

+++ b/content/browser/compositor/surface_utils.cc

@@ -76,7 +76,7 @@ void PrepareTextureCopyOutputResult(

if (!bitmap->tryAllocPixels(SkImageInfo::Make(

dst_size_in_pixel.width(), dst_size_in_pixel.height(), color_type,

kOpaque_SkAlphaType))) {

- scoped_callback_runner.Reset(base::Bind(

+ scoped_callback_runner.ReplaceClosure(base::Bind(

no sievers 2016/07/06 19:12:13 Ah so |callback| ended up getting called twice?

Sergey Ulanov 2016/07/06 19:13:32 Correct. Previously Reset() was calling the old ca

callback, SkBitmap(), content::READBACK_BITMAP_ALLOCATION_FAILURE));

return;

}