DescriptionReland of Data structures for Safe Browsing subresource filtering rules. (patchset #1 id:1 of https://codereview.chromium.org/2098453002/ )
Reason for revert:
Build failure could not be reproduced on any other builder, nor locally, nor on a locally run buildbot slave with the same configuration. Build output is void of any error details.
Speculative reland to verify that the failure is real, and not just the builder needing a clobber.
Original issue's description:
> Revert of Data structures for Safe Browsing subresource filtering rules. (patchset #4 id:160001 of https://codereview.chromium.org/2086213003/ )
>
> Reason for revert:
> I think this is causing compile errors on
> https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/12018.
>
> [5683/25038] STAMP obj/components/subresource_filter/core/common/flat/flatbuffer_gen.inputdeps.stamp
> [5684/25038] ACTION //components/subresource_filter/core/common/flat:flatbuffer_gen(//build/toolchain/linux:clang_x64)
> FAILED: gen/components/subresource_filter/core/common/flat/rules_generated.h
> python ../../build/gn_run_binary.py flatc -c -o gen/components/subresource_filter/core/common/flat ../../components/subresource_filter/core/common/flat/rules.fbs
>
> Original issue's description:
> > Data structures for Safe Browsing subresource filtering rules.
> >
> > The rules are defined in two formats:
> >
> > 1) Protocol Buffers, which is used as the wire format for transferring the
> > rules, and is intended to remain relatively stable.
> >
> > 2) FlatBuffers, which is used internally as a compact representation of the
> > rules, and which can be memory mapped into renderer processes directly.
> >
> > This CL also fixes GYP files for flatc for iOS.
> >
> > BUG=609747
> >
> > Committed: https://crrev.com/2f6afa6d80d6c2addb3b95626140327570151e14
> > Cr-Commit-Position: refs/heads/master@{#401563}
>
> TBR=engedy@chromium.org,pkalinnikov@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=609747
>
> Committed: https://crrev.com/b5156c9ef3a959038e2ca485d6e43c559bd57b4a
> Cr-Commit-Position: refs/heads/master@{#401572}
TBR=pkalinnikov@chromium.org,hbos@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=609747
Committed: https://crrev.com/19a4c0cd8e6b0b60287f4f887f85067b19b78985
Cr-Commit-Position: refs/heads/master@{#401673}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|