Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2094753002: [heap] Use PageIterator in HeapObjectIterator (Closed)

Created:
4 years, 6 months ago by Michael Lippautz
Modified:
3 years, 6 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Use PageIterator in HeapObjectIterator BUG=chromium:581412 LOG=N R=jochen@chromium.org Committed: https://crrev.com/35720342c3a562b57413a257f3457da5cf8ee644 Cr-Commit-Position: refs/heads/master@{#37284}

Patch Set 1 #

Patch Set 2 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -111 lines) Patch
M src/heap/heap.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/spaces.h View 6 chunks +48 lines, -54 lines 2 comments Download
M src/heap/spaces.cc View 1 1 chunk +19 lines, -35 lines 0 comments Download
M src/heap/spaces-inl.h View 4 chunks +7 lines, -20 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2094753002/1
4 years, 6 months ago (2016-06-23 16:37:56 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/16518)
4 years, 6 months ago (2016-06-23 16:42:06 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2094753002/20001
4 years, 6 months ago (2016-06-23 17:26:04 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 17:55:19 UTC) #8
Michael Lippautz
ptal. just a bit more cleanup. https://codereview.chromium.org/2094753002/diff/20001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/2094753002/diff/20001/src/heap/spaces.h#newcode1579 src/heap/spaces.h:1579: class PageIteratorImpl Just ...
4 years, 6 months ago (2016-06-23 19:43:14 UTC) #11
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-06-27 08:13:05 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094753002/20001
4 years, 5 months ago (2016-06-27 08:34:11 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 08:59:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094753002/20001
4 years, 5 months ago (2016-06-27 11:32:31 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 11:34:21 UTC) #20
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/35720342c3a562b57413a257f3457da5cf8ee644 Cr-Commit-Position: refs/heads/master@{#37284}
4 years, 5 months ago (2016-06-27 11:37:13 UTC) #22
brucedawson
3 years, 6 months ago (2017-06-14 22:07:13 UTC) #24
Message was sent while issue was closed. 
https://codereview.chromium.org/2094753002/diff/20001/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/2094753002/diff/20001/src/heap/spaces.h#newco...
src/heap/spaces.h:1580: : public std::iterator<std::forward_iterator_tag,
PAGE_TYPE> {
It turns out that std::iterator is deprecated in C++ 17, and internal builds of
VC++ 2017 have started issuing deprecation warnings. We should think about
removing our usage of std::iterator.

An example removal from LLVM can be found here:

https://reviews.llvm.org/D34223

Powered by Google App Engine
This is Rietveld 408576698