Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Side by Side Diff: Source/bindings/v8/DebuggerScript.js

Issue 209473013: DevTools: Collect truncated scopes for async stacks. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/inspector/sources/debugger/async-callstack-scopes-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 // The frameMirror and scopeMirror can be accessed only while paused on the debugger. 328 // The frameMirror and scopeMirror can be accessed only while paused on the debugger.
329 var frameDetails = frameMirror.details(); 329 var frameDetails = frameMirror.details();
330 330
331 var funcObject = frameDetails.func(); 331 var funcObject = frameDetails.func();
332 var sourcePosition = frameDetails.sourcePosition(); 332 var sourcePosition = frameDetails.sourcePosition();
333 var thisObject = frameDetails.receiver(); 333 var thisObject = frameDetails.receiver();
334 334
335 var isAtReturn = !!frameDetails.isAtReturn(); 335 var isAtReturn = !!frameDetails.isAtReturn();
336 var returnValue = isAtReturn ? frameDetails.returnValue() : undefined; 336 var returnValue = isAtReturn ? frameDetails.returnValue() : undefined;
337 337
338 var scopeMirrors = (scopeDetailsLevel === DebuggerScript.ScopeInfoDetails.No Scopes ? [] : frameMirror.allScopes()); 338 var scopeMirrors = (scopeDetailsLevel === DebuggerScript.ScopeInfoDetails.No Scopes ? [] : frameMirror.allScopes(scopeDetailsLevel === DebuggerScript.ScopeIn foDetails.FastAsyncScopes));
yurys 2014/03/25 08:51:17 Is this parameter already supported in V8?
aandrey 2014/03/25 08:57:31 Surely. V8 change: https://codereview.chromium.org
339 var scopeTypes = new Array(scopeMirrors.length); 339 var scopeTypes = new Array(scopeMirrors.length);
340 var scopeObjects = new Array(scopeMirrors.length); 340 var scopeObjects = new Array(scopeMirrors.length);
341 for (var i = 0; i < scopeMirrors.length; ++i) { 341 for (var i = 0; i < scopeMirrors.length; ++i) {
342 var scopeDetails = scopeMirrors[i].details(); 342 var scopeDetails = scopeMirrors[i].details();
343 scopeTypes[i] = scopeDetails.type(); 343 scopeTypes[i] = scopeDetails.type();
344 scopeObjects[i] = scopeDetails.object(); 344 scopeObjects[i] = scopeDetails.object();
345 } 345 }
346 346
347 // Calculated lazily. 347 // Calculated lazily.
348 var scopeChain; 348 var scopeChain;
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
492 break; 492 break;
493 case ScopeType.Block: 493 case ScopeType.Block:
494 // Unsupported yet. Mustn't be reachable. 494 // Unsupported yet. Mustn't be reachable.
495 break; 495 break;
496 } 496 }
497 return result; 497 return result;
498 } 498 }
499 499
500 return DebuggerScript; 500 return DebuggerScript;
501 })(); 501 })();
OLDNEW
« no previous file with comments | « LayoutTests/inspector/sources/debugger/async-callstack-scopes-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698