Block all web requests until force enrollment status has been confirmed.

Block all web requests until force enrollment status has been confirmed.

This is still pending the actual check that is needed to decide if
filtering should occur or not.

BUG=352614
TEST=unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259280

[pastarmovj, 2014-03-24 19:35:02]

Hi Will, Mattias,
please review this CL.

@Mattias: As a whole
@Will: PorfileIOData changes.

Thanks!

[willchan no longer on Chromium, 2014-03-24 20:58:07]

lgtm

[Mattias Nissler (ping if slow), 2014-03-25 08:31:32]

https://codereview.chromium.org/209473008/diff/1/chrome/browser/policy/policy...
File chrome/browser/policy/policy_helpers.cc (right):

https://codereview.chromium.org/209473008/diff/1/chrome/browser/policy/policy...
chrome/browser/policy/policy_helpers.cc:21: if (url.SchemeIsHTTPOrHTTPS()) {
So FTP is still allowed? might just want to whitelist the schemes do want to
keep functional?

[Mattias Nissler (ping if slow), 2014-03-25 14:20:45]

This LGTM w/ nits.

https://codereview.chromium.org/209473008/diff/20001/chrome/browser/policy/po...
File chrome/browser/policy/policy_helpers.cc (right):

https://codereview.chromium.org/209473008/diff/20001/chrome/browser/policy/po...
chrome/browser/policy/policy_helpers.cc:26:
chromeos::switches::kOobeGuestSession)) {
Is this indentation legit? My gut feeling is +4

https://codereview.chromium.org/209473008/diff/20001/chrome/browser/policy/po...
chrome/browser/policy/policy_helpers.cc:27: if (url.SchemeIs("http") ||
url.SchemeIs("https") || url.SchemeIs("ftp")) {
So you're still blacklisting stuff? Didn't we decide to white-list?

[pastarmovj, 2014-03-25 16:27:07]

The CQ bit was checked by pastarmovj@chromium.org

[commit-bot: I haz the power, 2014-03-25 16:27:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/209473008/70001

[commit-bot: I haz the power, 2014-03-25 19:01:13]

Change committed as 259280