Make Blink internal parts private dependencies.

Make Blink internal parts private dependencies.

The Blink target is not intended to expose Blink's platform and web
components, even though they should be built. A private dependency expresses
this.

As a result, fix several minor dependency issues that were hidden by transitive
public dependencies through Blink's internals.

Committed: https://crrev.com/3d035bdfbe935cf6d242a0ed7c6d70823ad211a7
Cr-Commit-Position: refs/heads/master@{#403689}

[jbroman, 2016-06-24 15:02:31]

jbroman@chromium.org changed reviewers:
+ brettw@chromium.org, esprehn@chromium.org

[jbroman, 2016-06-24 15:02:32]

I noticed that the "blink" target currently exposes Blink's internal platform
and web targets in public_deps, which allows including headers from these
targets, and allows targets to gain access to their public_deps (notably V8 and
GLES2) without an explicit dependency.

It's not too hard to make these dependencies private (i.e. link them, but not
expose their public headers). WDYT?

[esprehn, 2016-06-24 15:06:53]

lgtm

[esprehn, 2016-06-24 15:07:23]

On 2016/06/24 at 15:06:53, esprehn wrote:
> lgtm

More explicit is better in build rules. :)

[jbroman, 2016-06-24 15:30:53]

Description was changed from

==========
Make Blink internal parts private dependencies.

The Blink target is not intended to expose Blink's platform and wtf
components, even though they should be built. A private dependency expresses
this.

As a result, fix several minor dependency issues that were hidden by transitive
public dependencies through Blink's internals.
==========

to

==========
Make Blink internal parts private dependencies.

The Blink target is not intended to expose Blink's platform and web
components, even though they should be built. A private dependency expresses
this.

As a result, fix several minor dependency issues that were hidden by transitive
public dependencies through Blink's internals.
==========

[jbroman, 2016-06-24 15:31:21]

jbroman@chromium.org changed required reviewers:
+ brettw@chromium.org, esprehn@chromium.org

[jbroman, 2016-06-28 21:40:22]

ping brettw for gn?

[brettw, 2016-07-03 23:28:10]

lgtm

[jbroman, 2016-07-04 00:45:09]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-07-04 00:45:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 00:48:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-04 00:48:15]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jbroman, 2016-07-04 15:14:58]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-07-04 15:14:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2094723002/#ps80001
(title: "//components/scheduler now also has a public dep on //v8")

[commit-bot: I haz the power, 2016-07-04 15:15:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 15:59:38]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-04 16:00:57]

Description was changed from

==========
Make Blink internal parts private dependencies.

The Blink target is not intended to expose Blink's platform and web
components, even though they should be built. A private dependency expresses
this.

As a result, fix several minor dependency issues that were hidden by transitive
public dependencies through Blink's internals.
==========

to

==========
Make Blink internal parts private dependencies.

The Blink target is not intended to expose Blink's platform and web
components, even though they should be built. A private dependency expresses
this.

As a result, fix several minor dependency issues that were hidden by transitive
public dependencies through Blink's internals.

Committed: https://crrev.com/3d035bdfbe935cf6d242a0ed7c6d70823ad211a7
Cr-Commit-Position: refs/heads/master@{#403689}
==========

[commit-bot: I haz the power, 2016-07-04 16:00:58]

Patchset 5 (id:??) landed as
https://crrev.com/3d035bdfbe935cf6d242a0ed7c6d70823ad211a7
Cr-Commit-Position: refs/heads/master@{#403689}