Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2094703005: MD Settings: Fix broken regulatory label in About on Samus (Closed)

Created:
4 years, 6 months ago by michaelpg
Modified:
4 years, 5 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix broken regulatory label in About on Samus BUG=546841 R=dpapad@chromium.org TEST=put something in /usr/share/chromeos-assets/regulatory_labels/us/label.{png,txt} or test on a samus CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation NOPRESUBMIT=true # unrelated html errors, will fix later Committed: https://crrev.com/807efe514f3fc8e64c59c1ea688cf95706fd15ef Cr-Commit-Position: refs/heads/master@{#402337}

Patch Set 1 #

Total comments: 3

Patch Set 2 : feedback #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M chrome/browser/resources/settings/about_page/about_page.html View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/about_handler.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/about_handler.cc View 1 3 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
michaelpg
PTAL. URL was missing the "label.png" ending so the image was broken.
4 years, 6 months ago (2016-06-24 07:21:48 UTC) #2
dpapad
lgtm https://codereview.chromium.org/2094703005/diff/1/chrome/browser/ui/webui/settings/about_handler.cc File chrome/browser/ui/webui/settings/about_handler.cc (right): https://codereview.chromium.org/2094703005/diff/1/chrome/browser/ui/webui/settings/about_handler.cc#newcode624 chrome/browser/ui/webui/settings/about_handler.cc:624: if (label_dir.empty()) { label_dir.empty() makes it looks as ...
4 years, 6 months ago (2016-06-24 16:29:20 UTC) #3
michaelpg
https://codereview.chromium.org/2094703005/diff/1/chrome/browser/ui/webui/settings/about_handler.cc File chrome/browser/ui/webui/settings/about_handler.cc (right): https://codereview.chromium.org/2094703005/diff/1/chrome/browser/ui/webui/settings/about_handler.cc#newcode624 chrome/browser/ui/webui/settings/about_handler.cc:624: if (label_dir.empty()) { On 2016/06/24 16:29:19, dpapad wrote: > ...
4 years, 6 months ago (2016-06-24 16:37:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094703005/20001
4 years, 6 months ago (2016-06-24 16:38:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/206801)
4 years, 6 months ago (2016-06-24 16:45:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094703005/20001
4 years, 6 months ago (2016-06-24 16:54:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094703005/20001
4 years, 6 months ago (2016-06-24 17:01:22 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/234004)
4 years, 6 months ago (2016-06-24 17:49:29 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094703005/40001
4 years, 5 months ago (2016-06-27 22:30:15 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-28 00:14:15 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 00:17:35 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/807efe514f3fc8e64c59c1ea688cf95706fd15ef
Cr-Commit-Position: refs/heads/master@{#402337}

Powered by Google App Engine
This is Rietveld 408576698