|
|
Created:
4 years, 6 months ago by michaelpg Modified:
4 years, 5 months ago Reviewers:
dpapad CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Fix broken regulatory label in About on Samus
BUG=546841
R=dpapad@chromium.org
TEST=put something in /usr/share/chromeos-assets/regulatory_labels/us/label.{png,txt}
or test on a samus
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true # unrelated html errors, will fix later
Committed: https://crrev.com/807efe514f3fc8e64c59c1ea688cf95706fd15ef
Cr-Commit-Position: refs/heads/master@{#402337}
Patch Set 1 #
Total comments: 3
Patch Set 2 : feedback #Patch Set 3 : rebase #
Messages
Total messages: 24 (13 generated)
Description was changed from ========== MD Settings: Fix broken regulatory label in About on Samus BUG=546841 R=dpapad@chromium.org TEST=put something in /usr/share/chromeos-assets/regulatory_labels/us/label.{png,txt} or test on a samus ========== to ========== MD Settings: Fix broken regulatory label in About on Samus BUG=546841 R=dpapad@chromium.org TEST=put something in /usr/share/chromeos-assets/regulatory_labels/us/label.{png,txt} or test on a samus CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
PTAL. URL was missing the "label.png" ending so the image was broken.
lgtm https://codereview.chromium.org/2094703005/diff/1/chrome/browser/ui/webui/set... File chrome/browser/ui/webui/settings/about_handler.cc (right): https://codereview.chromium.org/2094703005/diff/1/chrome/browser/ui/webui/set... chrome/browser/ui/webui/settings/about_handler.cc:624: if (label_dir.empty()) { label_dir.empty() makes it looks as if this is checking whether the directory is empty. Perhaps rename to label_dir_path would make it more intuitive. https://codereview.chromium.org/2094703005/diff/1/chrome/browser/ui/webui/set... chrome/browser/ui/webui/settings/about_handler.cc:646: label_dir.AppendASCII(kRegulatoryLabelImageFilename).MaybeAsASCII(); Ah, thanks for fixing, I understand the bug now.
https://codereview.chromium.org/2094703005/diff/1/chrome/browser/ui/webui/set... File chrome/browser/ui/webui/settings/about_handler.cc (right): https://codereview.chromium.org/2094703005/diff/1/chrome/browser/ui/webui/set... chrome/browser/ui/webui/settings/about_handler.cc:624: if (label_dir.empty()) { On 2016/06/24 16:29:19, dpapad wrote: > label_dir.empty() makes it looks as if this is checking whether the directory is > empty. Perhaps rename to label_dir_path would make it more intuitive. Done.
The CQ bit was checked by michaelpg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org Link to the patchset: https://codereview.chromium.org/2094703005/#ps20001 (title: "feedback")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== MD Settings: Fix broken regulatory label in About on Samus BUG=546841 R=dpapad@chromium.org TEST=put something in /usr/share/chromeos-assets/regulatory_labels/us/label.{png,txt} or test on a samus CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Fix broken regulatory label in About on Samus BUG=546841 R=dpapad@chromium.org TEST=put something in /usr/share/chromeos-assets/regulatory_labels/us/label.{png,txt} or test on a samus CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation NOPRESUBMIT=true # unrelated html errors, will fix later ==========
The CQ bit was checked by michaelpg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by michaelpg@chromium.org
The CQ bit was checked by michaelpg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by michaelpg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org Link to the patchset: https://codereview.chromium.org/2094703005/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Fix broken regulatory label in About on Samus BUG=546841 R=dpapad@chromium.org TEST=put something in /usr/share/chromeos-assets/regulatory_labels/us/label.{png,txt} or test on a samus CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation NOPRESUBMIT=true # unrelated html errors, will fix later ========== to ========== MD Settings: Fix broken regulatory label in About on Samus BUG=546841 R=dpapad@chromium.org TEST=put something in /usr/share/chromeos-assets/regulatory_labels/us/label.{png,txt} or test on a samus CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation NOPRESUBMIT=true # unrelated html errors, will fix later ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Fix broken regulatory label in About on Samus BUG=546841 R=dpapad@chromium.org TEST=put something in /usr/share/chromeos-assets/regulatory_labels/us/label.{png,txt} or test on a samus CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation NOPRESUBMIT=true # unrelated html errors, will fix later ========== to ========== MD Settings: Fix broken regulatory label in About on Samus BUG=546841 R=dpapad@chromium.org TEST=put something in /usr/share/chromeos-assets/regulatory_labels/us/label.{png,txt} or test on a samus CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation NOPRESUBMIT=true # unrelated html errors, will fix later Committed: https://crrev.com/807efe514f3fc8e64c59c1ea688cf95706fd15ef Cr-Commit-Position: refs/heads/master@{#402337} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/807efe514f3fc8e64c59c1ea688cf95706fd15ef Cr-Commit-Position: refs/heads/master@{#402337} |