Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: build/config/mac/mac_sdk.gni

Issue 2094693002: [Mac/GN] Print a warning if the SDK version is 10.11 but Xcode is <7.3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make fatal Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 6
7 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453. 7 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453.
8 # We can drop the rtc_require_mac_10_7_deployment flag when Chromium 8 # We can drop the rtc_require_mac_10_7_deployment flag when Chromium
9 # also requires a 10.7 deployment target. 9 # also requires a 10.7 deployment target.
10 import("//build_overrides/build.gni") 10 import("//build_overrides/build.gni")
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 if (mac_sdk_path == "") { 44 if (mac_sdk_path == "") {
45 mac_sdk_path = find_sdk_lines[0] 45 mac_sdk_path = find_sdk_lines[0]
46 } 46 }
47 47
48 script_name = "//build/config/mac/sdk_info.py" 48 script_name = "//build/config/mac/sdk_info.py"
49 _mac_sdk_result = exec_script(script_name, [ mac_sdk_name ], "scope") 49 _mac_sdk_result = exec_script(script_name, [ mac_sdk_name ], "scope")
50 mac_sdk_build = _mac_sdk_result.sdk_build 50 mac_sdk_build = _mac_sdk_result.sdk_build
51 xcode_version = _mac_sdk_result.xcode_version 51 xcode_version = _mac_sdk_result.xcode_version
52 xcode_build = _mac_sdk_result.xcode_build 52 xcode_build = _mac_sdk_result.xcode_build
53 machine_os_build = _mac_sdk_result.machine_os_build 53 machine_os_build = _mac_sdk_result.machine_os_build
54
55 if (mac_sdk_version != mac_sdk_min_build_override &&
56 exec_script("//build/check_return_value.py",
57 [
58 "test",
59 xcode_version,
60 "-ge",
61 "0730",
62 ],
63 "value") != 1) {
64 print(
65 "************************************************************************* *******")
66 print(
67 " WARNING: The Mac OS X SDK is incompatible with the version of Xcode. To fix,")
68 print(
69 " either upgrade Xcode to the latest version or install the Mac O S X")
70 print(
71 " $mac_sdk_min_build_override SDK. For more information, see http s://crbug.com/620127.")
72 print()
73 print(" Current SDK Version: $mac_sdk_version")
74 print(" Current Xcode Version: $xcode_version ($xcode_build)")
75 print(
76 "************************************************************************* *******")
77 assert(false, "SDK is incompatible with Xcode")
78 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698